Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icon on admin menu #50

Closed
wants to merge 1 commit into from
Closed

Change icon on admin menu #50

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 6, 2019

All Submissions:

Changes proposed in this Pull Request:

Change the icon on the main admin menu. This is a temporary fix until we get our own font set. It uses one of the standard CMS dashicons (shopping cart).

icon

How to test the changes in this Pull Request:

  1. Copy the revised menu.css file into a test site into assets > css
  2. Visit admin area of website

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Changelog entry

Change the admin main menu icon to remove Woo icon.

@bahiirwa
Copy link
Collaborator

bahiirwa commented Oct 7, 2019

@ghost
Copy link
Author

ghost commented Oct 7, 2019

This is just a temporary fix to get rid of Woo.

We have a logo and possible font. But we need someone to make up the whole works. All we have at this stage is one or two large images. No icons, etc. Should we approach Michelle and ask her if she has time to do something for us?

@bahiirwa
Copy link
Collaborator

bahiirwa commented Oct 7, 2019

It's worth a try. I know we need to make this an SVG or PNG to hook it up in the icons. I think we should nail the branding task in one swoop so we don't leave any bad marks behind.

I wonder if CP will have some more dashicons too in the near future.(wild thoughts)

@bahiirwa bahiirwa added Feedback help wanted Extra attention is needed labels Oct 7, 2019
@ghost
Copy link
Author

ghost commented Oct 7, 2019

OK - will ask Michelle for advice.

@ghost
Copy link
Author

ghost commented Oct 7, 2019

Michelle happy to help but needs the vector files. I have contacted Viktor (who did the original icon design) to see if he can supply them.

@bahiirwa bahiirwa added question Further information is requested and removed Needs Feedback labels Oct 9, 2019
@bahiirwa bahiirwa added this to the Version 1.0.0 milestone Oct 9, 2019
@bahiirwa
Copy link
Collaborator

Note: The .scss file compiles the .css file. Please make changes in the .scss file and compile the css using the instructions in the contributions instructions.

You will need to have node installed to run npm install && npm run build in your terminal after making the scss changes. This will match our build process. If you find issues here, I am willing to help push this.

@bahiirwa bahiirwa added On-Hold Need some more work before review and removed help wanted Extra attention is needed labels Oct 17, 2019
@ghost
Copy link
Author

ghost commented Oct 17, 2019

Still waiting to hear from Michelle re logos. This PR was just an interim solution, but I agree that we should get this sorted properly. Also note that I don't use node and have no idea what it does. And very vague on .scss too! Suggest we close this PR.

@bahiirwa
Copy link
Collaborator

No, let’s keep it open. We will work through it.

@bahiirwa
Copy link
Collaborator

@simplycomputing This is also broken as the branch is missing. Will you submit a new PR?

@ghost
Copy link
Author

ghost commented Oct 29, 2019

We can delete this as we will have to do something completely different if we are going with the svg for the dashicon.

@bahiirwa bahiirwa removed On-Hold Need some more work before review question Further information is requested labels Oct 31, 2019
@bahiirwa bahiirwa closed this Oct 31, 2019
@bahiirwa bahiirwa mentioned this pull request Oct 31, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant