This repository has been archived by the owner on Jun 19, 2019. It is now read-only.
Added "System" font support with weight specification + styling per window #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, some random stuff showed up in PR from our fork, let us re-create it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey
With iOS 9 Apple rolls out new system fonts logic: system font is now San Francisco, and system font depends on size (until 19pt it is ".SFUI-Text", after it is ".SFUI-Display"). To cover that we imagined that Classy could support font name "System" and then automatically on iOS 8 choosen Helvetica and on iOS 9 appropriate SF font.
In package as well
Tests
Label test in the app
Styling per window