More LCSC codes #30
Merged
More LCSC codes #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfvermut
force-pushed
the
feat/lcsc-codes
branch
from
40fc400
to
7725cd9
Compare
* fix(soundmodule): female socket instead of male headers * fix(motorsensor): J10 was upside-down * feat(pcb): rotate J10 and move lower, soundboard pin sockets * feat(pcb): add a corner line on a silkscreen for neopixel
There was a problem hiding this comment.
Looks good to me except for the fuse. I'm personally not a fan of these slow, resetable fuses. I can't see the benefit in this case, if any component gets 300W for 11sec you'll need to open the mower to repair anyways; Opening to "just" replace the fuse makes more sense to me.
| (property "Description" "LCSC links to resettable PTC" (id 7) (at 118.745 68.58 0) | ||
| (effects (font (size 1.27 1.27)) hide) | ||
| ) | ||
| (property "LCSC" "C369104" (id 8) (at 118.745 68.58 0) |
There was a problem hiding this comment.
Not sure if that is the right fuse to use. The fuse trips at 10A for 11 seconds. That's about 300W of power for 11 seconds, something is going to get hot.
There was a problem hiding this comment.
I'll find something faster in catalogue.
rfvermut
force-pushed
the
feat/lcsc-codes
branch
from
7725cd9
to
40c330f
Compare
|
Reverted fuses back to Ali fuse holders. Merged #24 changes in |
|
also added 3D model path fixes to this PR, now more components are rendered |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.