Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_default_battery_movement fails when battery feature is disabled #581

Closed
bowlofeggs opened this issue Sep 18, 2021 · 1 comment · Fixed by #582
Closed

test_default_battery_movement fails when battery feature is disabled #581

bowlofeggs opened this issue Sep 18, 2021 · 1 comment · Fixed by #582
Labels
bug Something isn't working the way that is expected.

Comments

@bowlofeggs
Copy link
Contributor

bowlofeggs commented Sep 18, 2021

Describe the bug

I'm working on upgrading Gentoo to bottom-0.6.4, and I'm seeing one test that fails when the battery feature is disabled:

---- test_default_battery_movement stdout ----
thread 'test_default_battery_movement' panicked at 'called `Result::unwrap()` on an `Err` value: ConfigError("\"battery\" is an invalid widget name.\n\nSupported widget names:\n+--------------------------+\n|            cpu           |\n+--------------------------+\n|        mem, memory       |\n+--------------------------+\n|       net, network       |\n+--------------------------+\n| proc, process, processes |\n+--------------------------+\n|     temp, temperature    |\n+--------------------------+\n|           disk           |\n+--------------------------+\n                ")', tests/layout_management_tests.rs:47:14
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

What operating system/architecture are you using?

This is a Gentoo container in podman on x86_64 (host is Fedora 33, though that's probably not relevant).

What terminal are you using bottom on?

gnome-terminal, though this is probably not relevant.

What version are you on?

0.6.4.

How did you install bottom?

I am building bottom from the 0.6.4 tag with Rust 1.53.0.

How can we reproduce this?

Run cargo test --no-default-features.

What is the actual behaviour?

See error output in Description above.

What is the expected behaviour?

Tests should pass, or automatically skip in environments they can't pass in.

@bowlofeggs bowlofeggs added the bug Something isn't working the way that is expected. label Sep 18, 2021
@bowlofeggs
Copy link
Contributor Author

I wonder if this test should be feature gated on the new battery feature.

bowlofeggs added a commit to bowlofeggs/bottom that referenced this issue Sep 18, 2021
test_default_battery_movement() is now feature gated on the
battery feature.

fixes ClementTsang#581

Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
@bowlofeggs bowlofeggs changed the title test_default_battery_movement fails in a Gentoo ebuild environment test_default_battery_movement fails when battery feature is disabled Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working the way that is expected.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant