Feature gate test_default_battery_movement #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_default_battery_movement() is now feature gated on the battery feature. fixes ClementTsang#581 Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
bowlofeggs
added a commit
to bowlofeggs/gentoo
that referenced
this pull request
Sep 18, 2021
I have applied patches here to address two vulnerable dependencies[0] and a failing test[1]. [0] ClementTsang/bottom#580 [1] ClementTsang/bottom#582 Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
bowlofeggs
added a commit
to bowlofeggs/gentoo
that referenced
this pull request
Sep 18, 2021
I have applied patches here to address two vulnerable dependencies[0] and a failing test[1]. [0] ClementTsang/bottom#580 [1] ClementTsang/bottom#582 Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
bowlofeggs
added a commit
to bowlofeggs/gentoo
that referenced
this pull request
Sep 18, 2021
I have applied patches here to address two vulnerable dependencies[0] and a failing test[1]. This fixes RUSTSEC-2021-0003[2] and RUSTSEC-2021-0093[3]. [0] ClementTsang/bottom#580 [1] ClementTsang/bottom#582 [2] https://rustsec.org/advisories/RUSTSEC-2021-0003 [3] https://rustsec.org/advisories/RUSTSEC-2021-0093 Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
ClementTsang
approved these changes
Sep 18, 2021
|
LGTM. @all-contributors add @bowlofeggs for code. |
|
I've put up a pull request to add @bowlofeggs! 🎉 |
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Sep 18, 2021
I have applied patches here to address two vulnerable dependencies[0] and a failing test[1]. This fixes RUSTSEC-2021-0003[2] and RUSTSEC-2021-0093[3]. [0] ClementTsang/bottom#580 [1] ClementTsang/bottom#582 [2] https://rustsec.org/advisories/RUSTSEC-2021-0003 [3] https://rustsec.org/advisories/RUSTSEC-2021-0093 Closes: #22328 Signed-off-by: Randy Barlow <randy@electronsweatshop.com> Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
test_default_battery_movement() is now feature gated on the
battery feature.
fixes #581
Signed-off-by: Randy Barlow randy@electronsweatshop.com
Issue
See #581 - Gentoo now passes tests with and without the feature enabled.
Closes: #581
Testing
I ran the test suite with and without the feature enabled, both on Fedora 33 and Gentoo's ebuild environment.
Furthermore, mark which platforms this change was tested on. All platforms directly affected by the change must be tested
Checklist
If relevant, ensure the following have been met:
cargo fmt)README.md, help menu, etc.)