Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cc-badge: border color visible in skeleton (dimmed & strong) #654

Closed
florian-sanders-cc opened this issue Dec 1, 2022 · 0 comments · Fixed by #655 or #656
Closed

cc-badge: border color visible in skeleton (dimmed & strong) #654

florian-sanders-cc opened this issue Dec 1, 2022 · 0 comments · Fixed by #655 or #656
Assignees
Labels
bug Something isn't working easy-quick-win

Comments

@florian-sanders-cc
Copy link
Contributor

Context

With #630 we've decided to go back to using a border instead of an inner box-shadow.
We've added border in dimmed and strong modes as well so that all modes have the same size.

I forgot to override the border also in skeleton mode which means we see the border color.
image
image

Solution

Set border color to the same color as the skeleton background.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working easy-quick-win
Projects
None yet
1 participant