Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-2851]: App Inbox parity for itemIndex parameter of the on onInboxItemClicked callback #410

Conversation

shivamsharma2710
Copy link
Contributor

Changed the value that we pass in the itemIndex parameter of the onInboxItemClicked callback.

Earlier it was the position of the item clicked from the list container. Now, it is the index of the content-page.
Default value for all the templates is 0 and it varies from 0 to number of pages for carousel templates.

…index) in the onInboxItemSelected callback instead of passing the item's index from the vertical App Inbox list
@shivamsharma2710 shivamsharma2710 changed the title refactor(SDK-2851): pass pageIndex(corresponds to the corouselPage's … [SDK-2851]: App Inbox parity for itemIndex parameter of the on onInboxItemClicked callback Mar 31, 2023
Copy link
Contributor

@piyush-kukadiya piyush-kukadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shivamsharma2710 shivamsharma2710 merged commit 9adbdb9 into master_android12 Mar 31, 2023
@piyush-kukadiya piyush-kukadiya deleted the task/SDK-2858/ios_pariy_for_index_parameter_in_onInboxItemSelected_callback branch September 9, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants