Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance Hit for MCMC on updating Manifest? #184

Closed
odunbar opened this issue Sep 27, 2022 · 0 comments · Fixed by #188
Closed

Performance Hit for MCMC on updating Manifest? #184

odunbar opened this issue Sep 27, 2022 · 0 comments · Fixed by #188
Assignees
@tsj5

Comments

@odunbar
Copy link
Collaborator

odunbar commented Sep 27, 2022 •
edited
Loading

Steps,

  1. Seems to happen for me on Julia 1.7.2 and 1.8.0
  2. delete Manifest.toml
  3. julia --project; ]; test

Leads to a massive slow down for (seemingly, just the) MCMC sampling.
@odunbar odunbar changed the title Performance Hit in Julia 1.8.0? Performance Hit for MCMC in Julia 1.8.0? Sep 27, 2022
@odunbar odunbar changed the title Performance Hit for MCMC in Julia 1.8.0? Performance Hit for MCMC on updating Manifest? Sep 27, 2022
@odunbar odunbar mentioned this issue Oct 1, 2022
Merged
bors bot added a commit that referenced this issue Oct 1, 2022
@bors @odunbar
Merge #188
d6543d5 
188: remove manifest, fix mcmc performance r=odunbar a=odunbar

## Purpose 
Removes manifest from project. Doing so caused performance hit, changed offending lines to regain performance.

## Content
- Fixes #184 
- Fixes #182 
- soft-fix for #169
- updates EKP compat to 0.13

Co-authored-by: odunbar <odunbar@caltech.edu>
@bors bors bot closed this as completed in 8d87f44 Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsj5 tsj5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove manifest, fix mcmc performance CliMA/CalibrateEmulateSample.jl
2 participants
@tsj5 @odunbar