Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalibrateEmulateSample dependence on EnsembleKalmanProcesses #106

Merged
merged 9 commits into from
Mar 9, 2021

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Mar 8, 2021

Purpose

To make CalibrateEmulateSample depend on EnsembleKalmanProcesses and its submodules

  • ParameterDistributionStorage
  • DataStorage
  • Observations
  • EnsembleKalmanProcessModule

Contains

  • The removal of the above packages, replaced with their import from EnsembleKalmanProcesses.They can still however be called by (for example) using CalibrateEmulateSample.DataStorage.
  • The removal of associated runtests and examples for the modules (moved to EnsembleKalmanProcesses)
  • Updated Project.toml and Manifest.toml (temporary)
  • I have updated the Wiki "getting started" page to work with the new framework
  • Also updated the example learn_noise.jl

A note on examples

Use the getting started wiki page to set up the corresponding example/Project.toml files, as they require both EnsembleKalmanProcesses and CalibrateEmulateSample packages.

@odunbar
Copy link
Collaborator Author

odunbar commented Mar 9, 2021

merging after offline comments and review

@odunbar
Copy link
Collaborator Author

odunbar commented Mar 9, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 9, 2021

Build succeeded:

@bors bors bot merged commit c382408 into master Mar 9, 2021
@bors bors bot deleted the orad/ces-deps branch March 9, 2021 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant