Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CES applied to EDMF for parametric uncertainty #170

Merged
merged 1 commit into from
Oct 18, 2022
Merged

CES applied to EDMF for parametric uncertainty #170

merged 1 commit into from
Oct 18, 2022

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Jul 18, 2022

Purpose and Content

To evaluate the efficacy of the E-S stages to an atmospheric calibration problem, where we have data from C-stage

In this PR:

  • zipped data files
  • script uq_for_EDMF.jlfor running CES and creating output files
  • script plot_posterior.jl for basic plotting of posterior marginals

TODO:

  • Document example

Current example outputs:

  1. exp_name = ent-det-calibration (takes ~40 mins)

  1. exp_name = ent-det-tked-tkee-stab-calibration (takes ~80mins)

@odunbar odunbar requested review from ilopezgp and szy21 July 18, 2022 19:01
@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Base: 88.65% // Head: 88.65% // No change to project coverage 👍

Coverage data is based on head (478e272) compared to base (8980d60).
Patch has no changes to coverable lines.

❗ Current head 478e272 differs from pull request most recent head 501fe11. Consider uploading reports for the commit 501fe11 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #170   +/-   ##
=======================================
  Coverage   88.65%   88.65%           
=======================================
  Files           4        4           
  Lines         388      388           
=======================================
  Hits          344      344           
  Misses         44       44           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

examples/EDMF_data/uq_for_edmf.jl Outdated Show resolved Hide resolved
examples/EDMF_data/uq_for_edmf.jl Show resolved Hide resolved
examples/EDMF_data/uq_for_edmf.jl Outdated Show resolved Hide resolved
Comment on lines +152 to +139
ParameterDistributions.ParameterDistribution.(
prior_dict_raw["distributions"],
prior_dict_raw["constraints"],
prior_dict_raw["u_names"],
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will have to change this when we use new data (not now). I am now storing the ParameterDistribution object directly.

@odunbar
Copy link
Collaborator Author

odunbar commented Oct 4, 2022

I'd like to make a bit of documentation for this example before merge. Could one of you add a little background to start it off? Or could this be obtained by linking to CEDMF or something?

@odunbar odunbar force-pushed the orad/UQ-EDMF branch 3 times, most recently from f8fafaf to cd86714 Compare October 5, 2022 20:18
Copy link
Collaborator Author

@odunbar odunbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but I can't approve my own PR.

new Project and Manifest

uq_for_edmf.jl

typo

short readme

clima format

added 5-parameter case

comment update

plotting from saved posterior

format

rm backup

added println

addressed PR comments from @szy21 and @ilopezgp

docs starter

docs/make.jl

add solution section

typo

typo

update docs

Minor changes to example docs
@odunbar
Copy link
Collaborator Author

odunbar commented Oct 18, 2022

bors r+

if !isfile(data_filepath)
LoadError("experiment data file \"Diagnostics.nc\" not found in directory \"" * exp_dir * "/\"")
else
y_truth = Array(NCDataset(data_filepath).group["reference"]["y_full"]) #ndata
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this syntax automatically close the opened files?

@bors
Copy link
Contributor

bors bot commented Oct 18, 2022

@bors bors bot merged commit fa7fc0c into master Oct 18, 2022
@bors bors bot deleted the orad/UQ-EDMF branch October 18, 2022 23:19
@odunbar odunbar changed the title [WIP] CES applied to EDMF for parametric uncertainty CES applied to EDMF for parametric uncertainty Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants