-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CES applied to EDMF for parametric uncertainty #170
Conversation
Codecov ReportBase: 88.65% // Head: 88.65% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #170 +/- ##
=======================================
Coverage 88.65% 88.65%
=======================================
Files 4 4
Lines 388 388
=======================================
Hits 344 344
Misses 44 44 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ParameterDistributions.ParameterDistribution.( | ||
prior_dict_raw["distributions"], | ||
prior_dict_raw["constraints"], | ||
prior_dict_raw["u_names"], | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will have to change this when we use new data (not now). I am now storing the ParameterDistribution object directly.
75ace89
to
d6b7b5a
Compare
I'd like to make a bit of documentation for this example before merge. Could one of you add a little background to start it off? Or could this be obtained by linking to CEDMF or something? |
f8fafaf
to
cd86714
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - but I can't approve my own PR.
new Project and Manifest uq_for_edmf.jl typo short readme clima format added 5-parameter case comment update plotting from saved posterior format rm backup added println addressed PR comments from @szy21 and @ilopezgp docs starter docs/make.jl add solution section typo typo update docs Minor changes to example docs
bors r+ |
if !isfile(data_filepath) | ||
LoadError("experiment data file \"Diagnostics.nc\" not found in directory \"" * exp_dir * "/\"") | ||
else | ||
y_truth = Array(NCDataset(data_filepath).group["reference"]["y_full"]) #ndata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this syntax automatically close the opened files?
Build succeeded: |
Purpose and Content
To evaluate the efficacy of the E-S stages to an atmospheric calibration problem, where we have data from C-stage
In this PR:
uq_for_EDMF.jl
for running CES and creating output filesplot_posterior.jl
for basic plotting of posterior marginalsTODO:
Current example outputs:
exp_name = ent-det-calibration
(takes ~40 mins)exp_name = ent-det-tked-tkee-stab-calibration
(takes ~80mins)