Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add figures to EDMF example #272

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Add figures to EDMF example #272

merged 3 commits into from
Jan 5, 2024

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Jan 3, 2024

Purpose

Close #273

NB this is still probably the weakest example as it doesn't have a walkthrough, and due to the computational expense I expect most users would not try to run it. but it is useful to keep and has some expected results now at least.

Content

  • add images in docs
  • reduce example to just a couple of cases

Docs found here


  • I have read and checked the items on the review checklist.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a621a04) 88.09% compared to head (5eb15d1) 88.16%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
+ Coverage   88.09%   88.16%   +0.07%     
==========================================
  Files           7        7              
  Lines        1134     1124      -10     
==========================================
- Hits          999      991       -8     
+ Misses        135      133       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odunbar odunbar changed the title [WIP] clean up EDMF example Add figures to EDMF example Jan 4, 2024
@odunbar
Copy link
Collaborator Author

odunbar commented Jan 5, 2024

merging, this just adds premade figures, and removes code-branches that are not run

@odunbar odunbar merged commit 6ce27ff into main Jan 5, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add figures to EDMF examples, adjust for JLD2 updates
1 participant