Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS: Emulator docstring and warning #299

Merged
merged 12 commits into from
Apr 5, 2024
Merged

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Apr 4, 2024

Purpose

Addressing #294

Content

  • Added a comprehensive dosctring for Emulator(...)
  • Added a warning when not providing obs_noise_cov as a keyword

Due to the way manifests/GH actions work, will need a later PR to add the docs for this change


  • I have read and checked the items on the review checklist.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.27%. Comparing base (acf1051) to head (a9d285d).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   88.17%   88.27%   +0.09%     
==========================================
  Files           8        8              
  Lines        1184     1185       +1     
==========================================
+ Hits         1044     1046       +2     
+ Misses        140      139       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odunbar odunbar merged commit 5883125 into main Apr 5, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant