Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS address editor comments #305

Merged
merged 13 commits into from
Apr 23, 2024
Merged

JOSS address editor comments #305

merged 13 commits into from
Apr 23, 2024

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Apr 18, 2024

Purpose

Address Editor comments of openjournals/joss-reviews#6372 (comment)

Content

  • Updated (all attainable DOIs)
  • Attach Andre's ORCiD
  • research list now bulleted
  • CES pipeline description now an enumerated list
  • formating of e.g., i.e, for example, ...
  • Figure text is larger in all sinusoid example figs. (and edited the example scripts that produce them)

Not Addressed

  • Unattainable DOIs: (1) Random Features (Rahimi and Recht 2007) was published in NIPS and there are not DOIs for these conference papers that I can find. (2) SciKitLearn & (3) No-U-Turn sampler papers are published with JMLR which also does not give DOIs.
  • Author has requested their name remains N. Efrat-Henrici

  • I have read and checked the items on the review checklist.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.18%. Comparing base (acf1051) to head (e54c79e).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #305   +/-   ##
=======================================
  Coverage   88.17%   88.18%           
=======================================
  Files           8        8           
  Lines        1184     1185    +1     
=======================================
+ Hits         1044     1045    +1     
  Misses        140      140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odunbar
Copy link
Collaborator Author

odunbar commented Apr 23, 2024

Merged before PR reviewed - as JOSS editor will review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant