WIP: replace Prior and posterior samples with ParameterDistributions #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
+ Coverage 79.81% 85.19% +5.37%
==========================================
Files 8 7 -1
Lines 540 547 +7
==========================================
+ Hits 431 466 +35
+ Misses 109 81 -28
Continue to review full report at Codecov.
|
|
Recieved a review offline from @bielim . Merging |
|
bors r+ |
|
Build succeeded: |
bielim
pushed a commit
that referenced
this pull request
Dec 18, 2020
3 tasks
bielim
pushed a commit
that referenced
this pull request
Dec 22, 2020
3 tasks
bors bot
added a commit
that referenced
this pull request
Dec 22, 2020
94: Update examples to work with the latest CES code r=bielim a=bielim The goal of this PR is to get all examples synced up with the latest changes in the code base (in particular, PRs #88 and #89) - [x] `Cloudy_example.jl` - [x] `learn_noise.jl` - [x] `plot_GP.jl` In addition, `get_distribution()` (in `ParameterDistribution.jl`) has been modified to return the array of samples when called for `Samples` ( rather than the message "Contains samples only"). `get_distribution` now returns a `Dict` with the parameter names as keys and the corresponding distribution (in the case of `Parameterized` distributions, such as Normal(0.0, 1.0)) or the corresponding samples (in the case of parameters represented by `Samples`) as a parameter_dimension x n_samples array. Co-authored-by: Melanie <melanie@charney.bieli.email>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To follow from PR #88 in replacing the prior distributions and posterior distributions with the new type ParameterDistributions, and adding the requisite functionality to make this possible.
Contained in the PR
get_logpdf,get_cov,get_meanand replace implementation in EKP, and MCMC. Note this will also allow us to use prior distributions with block diagonal (i.e not only diagonal) in the MCMC.runtests.jlthat are dependent onPriors.jl, to instead use ParameterDistributionsFuture PR will deal with example cases (not contained in runtests)
Additionally