Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial tests of unequal sized images #165

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Initial tests of unequal sized images #165

wants to merge 1 commit into from

Conversation

kmdeck
Copy link
Collaborator

@kmdeck kmdeck commented Dec 8, 2023

Purpose

Adds tests for cases where images do not have equal number of pixels in each dimension.

Our current code seems to run fine, so this only adds tests.

To-do

carry out a test with a dataset?
rebase and merge

Content

updates tests to have the case where nx is not equal to ny

Review checklist

I have:

In the Content, I have included

  • relevant unit tests, and integration tests,
  • appropriate docstrings on all functions, structs, and modules, and included relevant documentation.

  • I have read and checked the items on the review checklist.

@kmdeck kmdeck self-assigned this Dec 8, 2023
@kmdeck kmdeck requested a review from bischtob February 23, 2024 23:40
@kmdeck
Copy link
Collaborator Author

kmdeck commented Mar 7, 2024

we assume this in sampling says @sandreza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant