Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ESM-SnowMIP data #19

Merged
merged 1 commit into from
May 24, 2024
Merged

added ESM-SnowMIP data #19

merged 1 commit into from
May 24, 2024

Conversation

kmdeck
Copy link
Contributor

@kmdeck kmdeck commented May 22, 2024

Adds the ESM-SnowMIP data - met and snow data for 10 sites, along with some site metadata.

Checklist:

  • I created a new folder $artifact_name
    • I added a README.md in that that folder that
      • describes the data and processing done to it
      • lists the sources of the raw data
      • lists the required citation, licenses
    • If applicable (e.g., for Creative Commons), I added a LICENSE file [KMD: noted in README instead]
    • I added the scripts that retrieve, process, and produce the artifact
    • I added the environment used for such scripts (typically, Project.toml
      and Manifest.toml)
    • I added the OutputArtifacts.toml file containing the information
      needed for package developers to add $artifact_name to their package
  • I uploaded the artifact folder to the Caltech cluster (in
    /groups/esm/ClimaArtifacts/artifacts/$artifact_name)
  • I added the relevant code to the Overides.toml on the Caltech Cluster
    (in /groups/esm/ClimaArtifacts/artifacts/Overrides.toml)
  • I added a link to the main README.md to point to the new artifact

@kmdeck kmdeck self-assigned this May 22, 2024
@kmdeck
Copy link
Contributor Author

kmdeck commented May 22, 2024

@Sbozzolo I did not upload to the cluster because this is a small file (60MB). let me know if I still need to (I thought that was only for large files)

@kmdeck kmdeck requested a review from szy21 May 22, 2024 20:23
@Sbozzolo
Copy link
Member

@Sbozzolo I did not upload to the cluster because this is a small file (60MB). let me know if I still need to (I thought that was only for large files)

I would still recommend uploading it. It is not very big, but it will save downloading 60MB every time the package has to be reinstantiated (which hopefully is not often given that use a depot)

snowmip/README.md Outdated Show resolved Hide resolved
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, after addressing Gabriele's comments.

@kmdeck kmdeck merged commit 8248691 into main May 24, 2024
@kmdeck kmdeck deleted the snowmip_data branch May 24, 2024 21:30
@kmdeck kmdeck linked an issue May 24, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

O2.1.4 Test snow model at different sites
3 participants