Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration of ClimaCoreSpectra in ClimaAtmos #994

Closed
2 tasks done
valeriabarra opened this issue Oct 20, 2022 · 0 comments · Fixed by #1014
Closed
2 tasks done

Integration of ClimaCoreSpectra in ClimaAtmos #994

valeriabarra opened this issue Oct 20, 2022 · 0 comments · Fixed by #1014
Assignees
@valeriabarra
Labels
enhancement New feature or request Visualization 🎨

Comments

@valeriabarra
Copy link
Member

valeriabarra commented Oct 20, 2022 •
edited

Purpose

This is an issue to track the integration work of a ClimaCore feature in ClimaAtmos.
This issue is downstream of ClimaCore SDI #967

Objectives

  • Add spectrum calculations in the AMIP driver/postprocessing pipeline. Test case to be used for initial integration example is moist baroclinic wave

Components

  • Implement a Kinetic Energy spectrum calculator in the paperplots_moist_baro_wave_ρe function. The intent is (at least initially) to replicate the existing behavior in ClimateMachine, where we computed the spectrum of the u and v components separately and then computed the KE from these.

Producers

@valeriabarra

Reviewers/potential collaborators

Possibly @LenkaNovak and @jiahe23
@valeriabarra valeriabarra mentioned this issue Oct 20, 2022
Closed
15 tasks
@valeriabarra valeriabarra self-assigned this Oct 20, 2022
@valeriabarra valeriabarra mentioned this issue Oct 24, 2022
Merged
4 tasks
bors bot added a commit that referenced this issue Oct 26, 2022
@bors @valeriabarra
Merge #1014
8345a71 
1014: Integrate spectra calculator for moist baro wave ex r=valeriabarra a=valeriabarra

This PR will close #994 

## Purpose 
Integrate the use of `ClimaCoreSpectra` for spectra calculation in ClimaAtmos. 

Will close #994 .



## Content
Add spectrum calculations in the AMIP driver/postprocessing pipeline. The test case used for initial integration example is moist baroclinic wave. The intent is to replicate the existing behavior in [ClimateMachine](https://github.com/CliMA/ClimateMachine.jl/blob/master/src/Diagnostics/atmos_gcm_spectra.jl#L88) 
- Solution implemented as in the ClimateMachine implementation.

Review checklist

I have:
- [x] followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/
- [x] followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/
- [x] followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy
- [x] checked that this PR does not duplicate an open PR.


Co-authored-by: Valeria Barra <valeriabarra21@gmail.com>
@bors bors bot closed this as completed in f479fdd Oct 26, 2022
@valeriabarra valeriabarra mentioned this issue Nov 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valeriabarra valeriabarra

Labels
enhancement New feature or request Visualization 🎨
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Integrate spectra calculator for moist baro wave ex CliMA/ClimaAtmos.jl
1 participant
@valeriabarra