Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased allocations in latest released #881

Closed
charleskawczynski opened this issue Aug 10, 2022 · 3 comments
Closed

Increased allocations in latest released #881

charleskawczynski opened this issue Aug 10, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@charleskawczynski
Copy link
Member

In the latest release (I suspect #829 is responsible), we found in TC#1261 that allocations in initialization increased from 25GB to 40GB:

Before:

[ Info: The simulation has completed.
  | 258.535694 seconds (483.68 M allocations: 25.021 GiB, 5.09% gc time, 94.81% compilation time)

After

[ Info: The simulation has completed.
  | 312.802070 seconds (858.13 M allocations: 40.089 GiB, 7.48% gc time, 96.01% compilation time)

We should verify which set of changes did this and fix / add some sort of tests.

@charleskawczynski charleskawczynski added the bug Something isn't working label Aug 10, 2022
@charleskawczynski
Copy link
Member Author

This may be related to codegen, and one source of compile latency (which presumably may require allocations) is method ambiguities. It seems that, according to using Aqua; using ClimaCore; Aqua.test_all(ClimaCore) some of the pointwise functionality, which uses the (as of #829) inlined getidx, has (potentially) many method ambiguities from overloading several generic methods in Base. One thing we can try to do is to fix these ambiguities.

@charleskawczynski
Copy link
Member Author

We've fixed a handful of the ambiguities, I think the codegen is the remaining culprit I can think of

@charleskawczynski
Copy link
Member Author

Closed by #1113.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant