Improve performance of column operators #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/fix_col_perf
branch
from
d6bf6e7
to
acf7481
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
charleskawczynski
force-pushed
the
ck/fix_col_perf
branch
3 times, most recently
from
a2e7adf
to
e8f8e13
Compare
|
bors try |
tryBuild failed: |
charleskawczynski
force-pushed
the
ck/fix_col_perf
branch
from
e8f8e13
to
5645fe3
Compare
charleskawczynski
force-pushed
the
ck/fix_col_perf
branch
from
06b9dd7
to
2f28f6a
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 26, 2022
829: Improve performance of column operators r=charleskawczynski a=charleskawczynski This PR improves the performance of column operations by: - Adding ``@inline`` and ``@inbounds`` annotations - Fixing some type inference issues that prevented inlining (in `idxin`) Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
|
Build failed: |
charleskawczynski
force-pushed
the
ck/fix_col_perf
branch
from
2f28f6a
to
39a8b06
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 26, 2022
829: Improve performance of column operators r=charleskawczynski a=charleskawczynski This PR improves the performance of column operations by: - Adding ``@inline`` and ``@inbounds`` annotations - Fixing some type inference issues that prevented inlining (in `idxin`) Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
4 tasks
charleskawczynski
force-pushed
the
ck/fix_col_perf
branch
from
39a8b06
to
3cccbcb
Compare
|
Canceled. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 26, 2022
829: Improve performance of column operators r=charleskawczynski a=charleskawczynski This PR improves the performance of column operations by: - Adding ``@inline`` and ``@inbounds`` annotations - Fixing some type inference issues that prevented inlining (in `idxin`) Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
|
Build failed: |
charleskawczynski
force-pushed
the
ck/fix_col_perf
branch
from
3cccbcb
to
b5b0c87
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 26, 2022
829: Improve performance of column operators r=charleskawczynski a=charleskawczynski This PR improves the performance of column operations by: - Adding ``@inline`` and ``@inbounds`` annotations - Fixing some type inference issues that prevented inlining (in `idxin`) Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
|
Build failed: |
charleskawczynski
force-pushed
the
ck/fix_col_perf
branch
from
b5b0c87
to
78ffb5c
Compare
|
bors try |
charleskawczynski
force-pushed
the
ck/fix_col_perf
branch
from
56490b4
to
fb1ebb2
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 27, 2022
829: Improve performance of column operators r=charleskawczynski a=charleskawczynski This PR improves the performance of column operations by: - Adding ``@inline`` and ``@inbounds`` annotations - Fixing some type inference issues that prevented inlining (in `idxin`) Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
|
Build failed: |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 27, 2022
829: Improve performance of column operators r=charleskawczynski a=charleskawczynski This PR improves the performance of column operations by: - Adding ``@inline`` and ``@inbounds`` annotations - Fixing some type inference issues that prevented inlining (in `idxin`) Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
|
Build failed: |
charleskawczynski
force-pushed
the
ck/fix_col_perf
branch
from
fb1ebb2
to
94afac1
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 27, 2022
829: Improve performance of column operators r=charleskawczynski a=charleskawczynski This PR improves the performance of column operations by: - Adding ``@inline`` and ``@inbounds`` annotations - Fixing some type inference issues that prevented inlining (in `idxin`) Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
|
Build failed: |
Add @inbounds inside getidx Add @inline to some getidx and setidx Add @inline annot to getidx Add @inline annotations, some tests are fixed Nearly fix tests with unrolling idxin Fix merge conflict Add another example in comments Make tests less flakey, higher res Remove temporary main timings Apply formatter Fix JET failure Fix more tests More inline and fix tests More inlining Clean up Temporarily make bors not depend on windows ci Increase benchmark buffer Disable fail fast in GHA while windows is broken Try to do the right thing
charleskawczynski
force-pushed
the
ck/fix_col_perf
branch
from
94afac1
to
f2867bc
Compare
|
bors r+ |
This was referenced Aug 24, 2022
bors bot
added a commit
that referenced
this pull request
Aug 26, 2022
917: Do inlining and inbounds more carefully r=charleskawczynski a=charleskawczynski This PR is an attempt to partially revert (and complete) #829, by: - Exchanging the use of ``@inline`` and ``@inbounds`` - Removing ``@inline`` for "expensive" functions that do not have or uses indices which require boundscheck elision - Applying inlining and ``@inbounds`` to slab functions The only thing that I'm not 100% sure about is the ``@inbounds`` around the threading loops, does what I've done look okay? cc `@simonbyrne` Supersedes #891. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot
added a commit
that referenced
this pull request
Aug 26, 2022
917: Do inlining and inbounds more carefully r=charleskawczynski a=charleskawczynski This PR is an attempt to partially revert (and extend/complete) #829, by: - More properly using ``@inline`,` ``@inbounds`` and `Base.`@propagate_inbounds`` - Removing ``@inline`` for "expensive" functions that do not have or uses indices which require boundscheck elision - Applying inlining and ``@inbounds`` to slab functions The only thing that I'm not 100% sure about is the ``@inbounds`` around the threading loops, does what I've done look okay? cc `@simonbyrne` Supersedes #891. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot
added a commit
that referenced
this pull request
Aug 26, 2022
917: Do inlining and inbounds more carefully r=charleskawczynski a=charleskawczynski This PR is an attempt to partially revert (and extend/complete) #829, by: - More properly using ``@inline`,` ``@inbounds`` and `Base.`@propagate_inbounds`` - Removing ``@inline`` for "expensive" functions that do not have or uses indices which require boundscheck elision - Applying inlining and ``@inbounds`` to slab functions The only thing that I'm not 100% sure about is the ``@inbounds`` around the threading loops, does what I've done look okay? cc `@simonbyrne` Supersedes #891. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot
added a commit
that referenced
this pull request
Aug 26, 2022
917: Do inlining and inbounds more carefully r=charleskawczynski a=charleskawczynski This PR is an attempt to partially revert (and extend/complete) #829, by: - More properly using ``@inline`,` ``@inbounds`` and `Base.`@propagate_inbounds`` - Removing ``@inline`` for "expensive" functions that do not have or uses indices which require boundscheck elision - Applying inlining and ``@inbounds`` to slab functions The only thing that I'm not 100% sure about is the ``@inbounds`` around the threading loops, does what I've done look okay? cc `@simonbyrne` Supersedes #891. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot
added a commit
that referenced
this pull request
Aug 27, 2022
917: Do inlining and inbounds more carefully r=charleskawczynski a=charleskawczynski This PR is an attempt to partially revert (and extend/complete) #829, by: - More properly using ``@inline`,` ``@inbounds`` and `Base.`@propagate_inbounds`` - Removing ``@inline`` for "expensive" functions that do not have or uses indices which require boundscheck elision - Applying inlining and ``@inbounds`` to slab functions The only thing that I'm not 100% sure about is the ``@inbounds`` around the threading loops, does what I've done look okay? cc `@simonbyrne` Supersedes #891. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the performance of column operations by:
@inlineand@inboundsannotationsidxin)