Define array2field and field2array #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
requested review from
dennisYatunin,
Sbozzolo and
sriharshakandala
charleskawczynski
force-pushed
the
ck/array2field
branch
from
aa318b1
to
313d177
Compare
charleskawczynski
force-pushed
the
ck/array2field
branch
from
313d177
to
2d4635a
Compare
Sbozzolo
approved these changes
May 31, 2024
Comment on lines
+623
to
+627
| if sizeof(eltype(field)) != sizeof(eltype(parent(field))) | ||
| f_axis_size = sizeof(eltype(parent(field))) ÷ sizeof(eltype(field)) | ||
| error("unable to use field2array because each Field element is \ | ||
| represented by $f_axis_size array elements (must be 1)") | ||
| end |
There was a problem hiding this comment.
Would it be easy to add a test for this error?
There was a problem hiding this comment.
Yes, but I ran out of time this evening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves some of the
array2fieldandfield2arraymethods into ClimaCore (from ClimaAtmos). I also added some simple tests.