Remove IntervalTopology(::Mesh) method
#1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
requested review from
dennisYatunin,
Sbozzolo,
AlexisRenchon,
juliasloan25,
sriharshakandala and
nefrathenrici
charleskawczynski
force-pushed
the
ck/topo_device
branch
3 times, most recently
from
775f2b5
to
eed4ded
Compare
charleskawczynski
force-pushed
the
ck/topo_device
branch
3 times, most recently
from
a9b6686
to
0a7eab1
Compare
charleskawczynski
force-pushed
the
ck/topo_device
branch
2 times, most recently
from
065a31f
to
213e8da
Compare
charleskawczynski
added a commit
that referenced
this pull request
Jun 18, 2024
Remove `IntervalTopology(::Mesh)` method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
IntervalTopology(::Mesh)method, as it may be incompatible with the device based on the latestENV["CLIMACOMMS_DEVICE"]value. Instead, users are required to passdevice(or the context) into this method.This is breaking, but the fix is easy. Might as well rip the bandaid off.