-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
376: CTS and dss r=kmdeck a=kmdeck ## Purpose The bucket model is run in a 3d domain for the AMIP runs, which, when using ClimaCore, involves the spectral elements in the horizontal. This may mean we need to dss! the state, which we do not do. This PR adds dss! to bucket model via CTS ODEfunction interface. ## To-do Understand dt <0 case. (change in bucket_utils.jl). Make sure this does what we expect. Relase new ClimaLSM and update perf and experiment/AMIP/modular Manifests (currently testing with main branch of ClimaLSM) ## Content ClimaLSM has added a dss buffer to the auxiliary cache & has changed that object from a FieldVector to a NameTuple. The previous aux Fields are all stored in p.bucket, while the buffer is stored in p.dss_buffer_2d and p.dss_buffer_3d. We need both because the bucket has variables defined in 3d and on the surface of the 3d domain. We also change to use ClimaTimeSteppers which accepts a dss! function as an argument. this PR changes from using ODE's Euler timestepper to CTS RK4 timestepper, and passes in the ClimaLSM.dss! function. This should mean that the land state is dss-ed at each step. Closes #380 Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. ---- - [x] I have read and checked the items on the review checklist. Co-authored-by: kmdeck <kdeck@caltech.edu>
- Loading branch information
Showing
4 changed files
with
68 additions
and
61 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters