Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DSS usage for ClimaCore v0.10.25 #242

Closed
1 task
juliasloan25 opened this issue Feb 1, 2023 · 0 comments · Fixed by #244
Closed
1 task

Update DSS usage for ClimaCore v0.10.25 #242

juliasloan25 opened this issue Feb 1, 2023 · 0 comments · Fixed by #244
Assignees

Comments

@juliasloan25
Copy link
Member

juliasloan25 commented Feb 1, 2023

As of ClimaCore v0.10.25, Spaces.dss_interior_faces! and Spaces.dss_local_vertices! have been replaced with dss2!. Both ClimaCoupler and ClimaLSM need to be updated to use the new interface. Specifically, the deprecated functions are used in the Regridder code of both packages (which should also be moved to a shared location at some point).

Addressed by #244.

ClimaLSM issue #144 is the corresponding issue for ClimaLSM.

Coupler regridder using old functions
ClimaLSM regridder using old functions
new dss2! function
example using new dss2! which was previously using old functions
Coupler deleted commit with replaced functions

NB:

  • let Sriharsha know once this is done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant