Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to use new ClimaParameter handling #72

Closed
charleskawczynski opened this issue Jun 27, 2022 · 1 comment
Closed

Change to use new ClimaParameter handling #72

charleskawczynski opened this issue Jun 27, 2022 · 1 comment

Comments

@charleskawczynski
Copy link
Member

We should apply the new clima parameter handling. An example of how to do this is in this PR.

A success metric for closing this issue involves:

  • Having a centralized module for where clima parameters from dependency packages can be accessed (see, e.g., CloudMicrophysics.jl's Parameters module, which forwards methods for handling thermodynamic variables).
  • Removing Land.jl's dependence on CLIMAParameters (i.e., using CLIMAParameters / import CLIMAParameters does not live in Land/src/).
  • All parameters that were previously obtained from CLIMAParameters methods are obtained from the CLIMAParameters toml file

It may be more efficient to clean up / remove any old / unused code / tests before applying these changes since it's a bit involved.

@LenkaNovak
Copy link
Collaborator

refer to #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants