Use new way of handling clima parameters #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/climaparams
branch
from
5b3971c
to
7386129
Compare
|
This looks fine to me, Charlie! Thanks for upgrading. In this, it seems like we'll have LSMParameters holding the physical constants for other modules (surface fluxes, TD) as well as planet params, and then each specific model may introduce its own specific params (soil type, etc) and create a bigger struct like MyModelParams
We can discuss more if this makes sense or if the whole thing should be a flat list? I am going to go ahead and merge this, because to use the latest ClimaAtmos (with the hot fixes @szy21 and @jiahe23 pushed) in coupled sims, we also need to be using the latest parameters style in the land model. |
kmdeck
approved these changes
Jun 25, 2022
|
bors r+ |
|
Build succeeded: |
This was referenced Jun 27, 2022
mitraA90
pushed a commit
that referenced
this pull request
Dec 22, 2023
68: Use new way of handling clima parameters r=kmdeck a=charleskawczynski This PR applies the new way of handling clima parameters: - Adds a package module, `Parameters`, where we define a struct specifically for this packages parameters. - The struct from this module is then used in all places where we originally called CLIMAParameter methods (e.g., `Planet.grav(param_set)` becomes `Parameters.grav(param_set)`, and I've added some aliases so that this is a bit more terse - Removes the use of CLIMAParameters in `src/` completely - Adds a folder, `parameters` to the top-level package, where a parameter-creating function was added, which constructs the struct instance that houses all of the necessary parameters are need (from this package, and its dependencies). Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the new way of handling clima parameters:
Parameters, where we define a struct specifically for this packages parameters.Planet.grav(param_set)becomesParameters.grav(param_set), and I've added some aliases so that this is a bit more tersesrc/completelyparametersto the top-level package, where a parameter-creating function was added, which constructs the struct instance that houses all of the necessary parameters are need (from this package, and its dependencies).