Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests on GPU - plots #750

Closed
Tracked by #571
juliasloan25 opened this issue Apr 23, 2024 · 0 comments · Fixed by #749
Closed
Tracked by #571

tests on GPU - plots #750

juliasloan25 opened this issue Apr 23, 2024 · 0 comments · Fixed by #749
Assignees
Labels
GPU 🍃 leaf Issue coupled to a PR

Comments

@juliasloan25
Copy link
Member

juliasloan25 commented Apr 23, 2024

We want to be able to produce plots in GPU runs. This was partially implemented in a branch that wasn't merged into main (see here). It's accomplished by making a new space on the CPU, then copying fields from GPU to CPU. This will be slow and allocate a lot, but might still be worth it for debugging and postprocessing.

Maybe we should add a flag to optionally enable this in GPU runs, to avoid accidentally converting all the fields for plotting and slowing down GPU runs

Update: All plotting in the driver is currently controlled by 3 flags, energy_check, diagnostics, and ci_plots, so they can all easily be turned off (energy_check and ci_plots are off by default)

part of #571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GPU 🍃 leaf Issue coupled to a PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant