-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests on GPU - plots #749
tests on GPU - plots #749
Conversation
a01d372
to
543bcf4
Compare
@@ -0,0 +1,22 @@ | |||
anim: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This config is copied from config/ci_configs/slabplanet_atmos_diags.yml
. Once we remove job_id
from inside the config file, we won't need to have both the CPU and GPU versions (though we'll have to make sure we always use anim: false
for GPU runs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can always dispatch the plot_anim
on device and do nothing for GPU.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea!
4f10ad0
to
be088fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you, @juliasloan25 ! It would be good to include the debug plot output in the CI runs, otherwise it's good to go.
@@ -0,0 +1,22 @@ | |||
anim: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can always dispatch the plot_anim
on device and do nothing for GPU.
6cd0da1
to
c11daba
Compare
c11daba
to
5d4820f
Compare
Purpose
We want to be able to produce plots in GPU runs. The easiest way to do this is to create a CPU-based space and copy all of the data over to that, then plot them. This will allocate a lot, but will still be useful for debugging and postprocessing
ncep_visualizer.jl and amip_visualizer.jl already work on GPU.
closes #750
Note: I think this same approach could be applied to the animations in
viz_explorer
, but I think it would involve creating a new space/field on CPU for each field at each timestep we want to plot. This will be really resource intensive, and I don't think it's worth doing until we have a cleaner way of transferring fields from GPU to CPU.This was initially implemented in #614 but not merged there
To-do
To test