Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plotting problems after the last ClimaAtmos release #97

Closed
LenkaNovak opened this issue Jul 21, 2022 · 0 comments · Fixed by #100
Closed

Plotting problems after the last ClimaAtmos release #97

LenkaNovak opened this issue Jul 21, 2022 · 0 comments · Fixed by #100

Comments

@LenkaNovak
Copy link
Collaborator

LenkaNovak commented Jul 21, 2022 •
edited
Loading

Currently plotting anything based off the horizontal center space from ClimaAtmos@0.2.0 plots a distorted image, whereas plotting exactly the same field in ClimaAtmos@0.3.0 produces the expected plot. (even with the same versions of ClimaCorePlots and ClimaCore)

MWE:

# boundary_space = h_space # this line is for ClimaAtmos@0.2.0
# boundary_space = spaces.center_space # this line is for ClimaAtmos@0.3.0

local_geometry = Fields.local_geometry_field(boundary_space)
ϕ = local_geometry.coordinates.lat
ff = ones(boundary_space) .* sin.(ϕ .* FT((π/180)))

plot(ff)
savefig("f.png")

We need to update ClimaAtmos via a new release, as well as make the regrid_space consistent with the boundary space.
Screen Shot 2022-07-21 at 11 33 18 AM
Screen Shot 2022-07-21 at 11 32 58 AM
@LenkaNovak LenkaNovak mentioned this issue Jul 26, 2022
Merged
10 tasks
bors bot added a commit that referenced this issue Jul 26, 2022
@bors @LenkaNovak
Merge #100
cf298c8 
100: Update for compatibility with ClimaAtmos@0.3.0 r=LenkaNovak a=LenkaNovak

# PULL REQUEST

with `@kmdeck` 

## Purpose and Content
Update for the new ClimaAtmos release. 

## Benefits and Risks
- benefit - up to date with current branch, this will fix a plotting bug (#97 )
- risk - change of dependencies

## Linked Issues
- Closes #97 

## Other comments
- we identified an incompatibility in ClimaAtmos, so we will link to [this fix](CliMA/ClimaAtmos.jl#696) until ClimaAtmos@0.4.0 is released. (tagging `@charleskawczynski` for visibility)

## PR Checklist
- [x] This PR has a corresponding issue OR is linked to an SDI.
- [x] I have followed CliMA's codebase [contribution](https://clima.github.io/ClimateMachine.jl/latest/Contributing/) and [style](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) guidelines OR N/A.
- [x] I have followed CliMA's [documentation policy](https://github.com/CliMA/policies/wiki/Documentation-Policy).
- [x] I have checked all issues and PRs and I certify that this PR does not duplicate an open PR.
- [x] I linted my code on my local machine prior to submission OR N/A.
- [x] Unit tests are included OR N/A.
- [x] Code used in an integration test OR N/A.
- [x] All tests ran successfully on my local machine OR N/A.
- [x] All classes, modules, and function contain docstrings OR N/A.
- [x] Documentation has been added/updated OR N/A.


Co-authored-by: LenkaNovak <lenka@caltech.edu>
@bors bors bot closed this as completed in b178fcb Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update for compatibility with ClimaAtmos@0.3.0 CliMA/ClimaCoupler.jl
1 participant
@LenkaNovak