Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slab Ocean + Atmos Held-Suarez #10

Merged
merged 6 commits into from
Jul 13, 2021
Merged

Slab Ocean + Atmos Held-Suarez #10

merged 6 commits into from
Jul 13, 2021

Conversation

LenkaNovak
Copy link
Collaborator

@LenkaNovak LenkaNovak commented Jun 21, 2021

Coupled GCM (Held-Suarez setup from RQA) with a shell slab ocean. This is the final piece of the test suite performed with the DGModel.

Design:

Tests:

Outstanding issues:

  • diffusion can be added once available in the ESDGModel kernels
  • currently, there is a bug in LMARS numerical fluxes, leading to conservation breaking at the boundary; as an alternative, Roe fluxes can be used (but their moist version is yet to be implemented, and in the dry case Roe fluxes have been found more unstable due to their less extreme smoothing at boundaries). Due to this issues, the above conservation tests were only performed on the dry setup with dry Roe fluxes.

author Lenka  Novakova <lenka@Lenkas-iMac.local> 1623383329 -0700
committer Lenka Novak <lenkanovak@Lenkas-MacBook-Pro.local> 1625958663 -0700

slab ocean gcm from slab land scm

db

db
@LenkaNovak LenkaNovak marked this pull request as ready for review July 10, 2021 23:29
@codecov
Copy link

codecov bot commented Jul 10, 2021

Codecov Report

Merging #10 (83dc79f) into main (e743c9f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   40.98%   40.98%           
=======================================
  Files           4        4           
  Lines          61       61           
=======================================
  Hits           25       25           
  Misses         36       36           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e743c9f...83dc79f. Read the comment docs.

Lenka Novakova and others added 2 commits July 13, 2021 10:09
author Lenka  Novakova <lenka@Lenkas-iMac.local> 1623383329 -0700
committer Lenka Novak <lenkanovak@Lenkas-MacBook-Pro.local> 1625958663 -0700

slab ocean gcm from slab land scm

db

db

Update Manifest.toml

Fix register calls, remove broken T_ref access.
@LenkaNovak LenkaNovak merged commit c8e486b into main Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants