transition to using new bucket model version #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmdeck
commented
Sep 12, 2022
kmdeck
commented
Sep 12, 2022
kmdeck
commented
Sep 12, 2022
kmdeck
changed the title
kmdeck
commented
Sep 14, 2022
| anomaly = true | ||
| hs_sfc = false | ||
| Y.bucket.T_sfc = map(coords) do coord | ||
| Y.bucket.T = map(coords.subsurface) do coord |
There was a problem hiding this comment.
@LenkaNovak right now the anomaly is 0 - do we want to change this?
|
FWIW, longer runs seem to run into this now (at ~7 days) maxiter reached in saturation_adjustment: |
LenkaNovak
approved these changes
Sep 15, 2022
| @@ -47,11 +47,12 @@ function calculate_surface_fluxes_atmos_grid!(integrator, info_sfc) | |||
| FT = eltype(integrator.u.c.ρ) | |||
| thermo_params = CAP.thermodynamics_params(integrator.p.params) | |||
| surface_flux_params = CAP.surface_fluxes_params(integrator.p.params) | |||
| uₕ_int = Geometry.UVVector.(Spaces.level(Y.c.uₕ, 1)) | |||
There was a problem hiding this comment.
Doesn't this allocate more than previously?
issue with atmos u bugs fixed but not well formatting and should run, psnow zero swap boundary space for horizontal space updated utils revert change cli typo cleanup review comment
kmdeck
force-pushed
the
enhanced_bucket_amip
branch
from
ecee64b
to
30e5ef4
Compare
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Purpose and Content
This PR updates the coupler driver file and other helper files so that the coupled runs work with the new version of the bucket model (with snow, and with a multi layer heat equation).
To do: followup on CliMA/ClimaCore.jl#943
Benefits and Risks
The benefit of this is that our AMIP model will be slightly more realistic.
Linked Issues
(Provide references to any link issues. Use closes #issuenum to automatically close an open issue)
PR Checklist