Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FT values from structs #198

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Remove FT values from structs #198

merged 1 commit into from
Dec 21, 2022

Conversation

juliasloan25
Copy link
Member

Purpose

Update the coupler so that FT is not stored in structs. Storing types in struct fields is a performance issue-- the typeof(Float64) is a DataType, and the compiler cannot optimize fields of this type.

To-do

  • Remove FT from structs
  • Add float_type(struct) functions to extract FT from struct objects
  • Replace instances of struct.FT with float_type(struct)
  • I have read and checked the items on the review checklist.

@juliasloan25 juliasloan25 force-pushed the js/ft_structs branch 2 times, most recently from 6522ce4 to ca726f2 Compare December 20, 2022 06:31
@juliasloan25 juliasloan25 marked this pull request as ready for review December 20, 2022 06:32
charleskawczynski
charleskawczynski reviewed Dec 20, 2022
View reviewed changes
src/Utilities.jl Outdated Show resolved Hide resolved
@juliasloan25 juliasloan25 force-pushed the js/ft_structs branch 2 times, most recently from e3ec649 to 6653fcc Compare December 21, 2022 17:31
charleskawczynski
charleskawczynski reviewed Dec 21, 2022
View reviewed changes
src/Utilities.jl Outdated Show resolved Hide resolved
charleskawczynski
charleskawczynski approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's one method that's not really needed, but overall looks good!

@juliasloan25
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 21, 2022

Build succeeded:

@bors bors bot merged commit fd9af01 into main Dec 21, 2022
@bors bors bot deleted the js/ft_structs branch December 21, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleskawczynski charleskawczynski charleskawczynski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juliasloan25 @charleskawczynski