Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update modular driver to use BCReader module #204

Merged
merged 1 commit into from
Jan 10, 2023
Merged

update modular driver to use BCReader module #204

merged 1 commit into from
Jan 10, 2023

Conversation

juliasloan25
Copy link
Member

@juliasloan25 juliasloan25 commented Jan 3, 2023 •
edited
Loading

Purpose

The BCReader module was implemented by #175. Now the modular driver coupler_driver_modular.jl needs to be updated to use this instead of including coupler_utils/bcfile_reader.jl.

closes #189

To-do

  • Replace include line with import of BCReader module
  • Update calls of functions from BCReader
  • I have read and checked the items on the review checklist.

@juliasloan25 juliasloan25 self-assigned this Jan 3, 2023
LenkaNovak
LenkaNovak approved these changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @juliasloan25 !

@LenkaNovak
Copy link
Collaborator

Actually, I've just noticed that the Buildkite test is only running this driver for the slabplanet mode, so the BC functions are not being called. It would be good to add another Buildkite run of this driver in the AMIP mode.

@juliasloan25 juliasloan25 marked this pull request as ready for review January 6, 2023 16:08
LenkaNovak
LenkaNovak approved these changes Jan 6, 2023
View reviewed changes
Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now have more stringent criteria for codecov, so the test is failing in Utilities'jl. I would delete the heaviside function. Looks like we don't need it anymore. Hopefully that'll help it pass.

experiments/AMIP/moist_mpi_earth/coupler_utils/bcfile_reader.jl Show resolved Hide resolved
@juliasloan25
Copy link
Member Author

We now have more stringent criteria for codecov, so the test is failing in Utilities'jl. I would delete the heaviside function. Looks like we don't need it anymore. Hopefully that'll help it pass.

@LenkaNovak even after removing the heaviside function from Utilities.jl, codecov still fails. Should I add tests for the functions in Utilities.jl, or just merge it as-is?

@juliasloan25 juliasloan25 mentioned this pull request Jan 9, 2023
Closed
13 tasks
@juliasloan25 juliasloan25 force-pushed the js/bcreader_driver_mod branch 2 times, most recently from ff42d8a to 16ba680 Compare January 9, 2023 22:25
@juliasloan25
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 10, 2023

Build succeeded:

@bors bors bot merged commit 5c486a7 into main Jan 10, 2023
@bors bors bot deleted the js/bcreader_driver_mod branch January 10, 2023 17:51
@juliasloan25 juliasloan25 mentioned this pull request Jan 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LenkaNovak LenkaNovak LenkaNovak approved these changes

Assignees

@juliasloan25 juliasloan25

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add BCReader module functions to coupler_driver_modular
2 participants
@juliasloan25 @LenkaNovak