Online Diagnostics Module #206
Conversation
LenkaNovak
force-pushed
the
ln/interface-diagnostics
branch
from
f7b8c90
to
837199a
Compare
LenkaNovak
force-pushed
the
ln/interface-diagnostics
branch
8 times, most recently
from
6d60409
to
2bbfe9a
Compare
| @@ -71,7 +72,7 @@ if isinteractive() | |||
| parsed_args["vert_diff"] = true #hide | |||
| parsed_args["rad"] = "gray" #hide | |||
| parsed_args["microphy"] = "0M" #hide | |||
| parsed_args["energy_check"] = true | |||
| parsed_args["energy_check"] = false | |||
| # Arguments | ||
| - `cs`: [CoupledSimulation] containing info about the simulation | ||
| """ | ||
| trigger_callback(cs::CoupledSimulation, ::Monthly) = cs.dates.date[1] >= cs.dates.date1[1] ? true : false |
There was a problem hiding this comment.
why does this need the ::Monthly param?
There was a problem hiding this comment.
Right now it's more like a label for clarity. But in the future, we may want to have callbacks for Daily or EveryTimestep. This callback interface will probably change though once we start thinking about more complex timestepping.
| # Atmos diagnostics | ||
|
|
||
| """ | ||
| get_var(cs, ::Val{:T}) |
There was a problem hiding this comment.
add type to function definition in comment (for all get_var functions)
src/Diagnostics.jl
Outdated
| @@ -0,0 +1,215 @@ | |||
| #= | |||
There was a problem hiding this comment.
change #=, =# to """ per Valeria's recent docstring updates
src/Diagnostics.jl
Outdated
|
|
||
|
|
||
| """ | ||
| pre_save(::TimeMean, cs::CoupledSimulation, dg::DiagnosticsGroup |
There was a problem hiding this comment.
missing closing ) (and in line 196)
| save_time_format | ||
|
|
||
|
|
||
| FT = Float64 |
There was a problem hiding this comment.
could add loop for FT in (Float32, Float64) over all testsets to test both FTs
There was a problem hiding this comment.
Yeah, I thought about it too, but then saw that it's not really testing any fundamental dependencies on the FT, so I figured Float64 suffices. Trying to cut down on unnecessary CI ;)
LenkaNovak
force-pushed
the
ln/interface-diagnostics
branch
from
2bbfe9a
to
c080818
Compare
tests cleanup test fix check in test Manifest check in test Manifest temp temp dep temp clean temp fix dep fix dep fix dep fix test try format rebase fixes mpi test rebase clean amip data name fix rev fix dep fix dep fix dep fix
LenkaNovak
force-pushed
the
ln/interface-diagnostics
branch
from
358054e
to
5dda1fc
Compare
|
bors r+ |
Purpose
Modularize the diagnostics utility.
To-do
trigger_callback(for better tracking of callback types) andMonthly()Note
Review checklist