Interface Postprocessor v2 #225
Conversation
LenkaNovak
force-pushed
the
ln/interface-postprocessor2
branch
from
7fd63b9
to
5342c09
Compare
docs/src/postprocessor.md
Outdated
| @@ -0,0 +1,24 @@ | |||
| # PostProcessor | |||
|
|
|||
| This module contains functions for postprocessing model data that was saved during the simulation by `ClimaCoupler.Diagnostics`). This module is used for offline regridding, slicing and spatial averages. It can also handle data from | |||
There was a problem hiding this comment.
line length too long, extra ")" after ClimaCoupler.Diagnostics
| @@ -0,0 +1,64 @@ | |||
| include("plot_helper.jl") | |||
There was a problem hiding this comment.
could make plot_helper a module and import it instead
There was a problem hiding this comment.
I thought about this too, but overall I concluded that this belongs to the code that is too specific to the experiment (along with specific diagnostics definitions), so it should really live in the experiments folder. If the plot helper is something we'll end up using in the long term for multiple experiments, then we can modularize it then. :)
| return all_plots | ||
| end | ||
|
|
||
| using Downloads |
There was a problem hiding this comment.
move imports to top of file?
| of the last monthly mean file. Any specific plot customization should be done here. | ||
| """ | ||
| function amip_paperplots( | ||
| post_spec, |
There was a problem hiding this comment.
could specify argument types
| of a particular monthly mean dataset (specified by `month_date`). Any plot NCEP- specific | ||
| customization should be done here. | ||
| """ | ||
| function ncep_paperplots( |
There was a problem hiding this comment.
could specify argument types
| end | ||
|
|
||
| """ | ||
| download_read_nc(https, tmp_dir, ncep_vname ) |
There was a problem hiding this comment.
comment doesn't match function signature
| using ClimaCoupler.PostProcessor: PostProcessedData, ZLatData, LatLonData, DataPackage, ZLatLonData | ||
| using Plots | ||
|
|
||
| function plot(post_data::DataPackage; zmd_params = (;), hsd_params = (;)) |
test/TestHelper.jl
Outdated
| @@ -14,7 +14,7 @@ export create_space, gen_ncdata | |||
|
|
|||
| """ | |||
| create_space(FT; comms_ctx = ClimaComms.SingletonCommsContext(), | |||
| R = FT(6371e3), ne = 4, polynomial_degree = 3) | |||
| R = FT(6371e3), ne = 4, polynomial_degree = 3, , nz = 1) | |||
LenkaNovak
force-pushed
the
ln/interface-postprocessor2
branch
from
5342c09
to
7195784
Compare
tests cleanup test fix check in test Manifest check in test Manifest temp temp dep temp clean temp fix dep fix dep fix dep fix test try format rebase fixes mpi test rebase clean amip data name fix postprocessor mod v2 format+deps fix fix dep fix ncep plot fix revs rev fix
LenkaNovak
force-pushed
the
ln/interface-postprocessor2
branch
from
7195784
to
ef94fbe
Compare
|
bors r+ |
Purpose
Modularize the offline postprocessor utility. 3826273012
To-do
update for CLimaComms 0.3.4 Update for ClimaComms 0.3.4 #208 (in tests and mpi_tests - 4x)(this will be more work than originally expected, so will be addressed as part of Update for ClimaComms 0.3.4 #208 )