Add flux module #320
Merged
Add flux module #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LenkaNovak
force-pushed
the
ln/flux-module
branch
from
c2086ee
to
2fa3ef1
Compare
LenkaNovak
force-pushed
the
ln/flux-module
branch
from
f8e65a5
to
31747fd
Compare
author LenkaNovak <lenka@caltech.edu> 1685729304 -0700 committer LenkaNovak <lenka@caltech.edu> 1686362388 -0700 init in src w tests update amip experiment slabplanet runs amip runs component model test passes fix combine_surfaces_from_sol! import viz fix add more unit tests docs and interface bug fixes conservation fix `combine_surfaces!` docstring fix revs rev2 doc comment apply update_field! and get_field in push_pull.jl fix fix slabplanet runs finalize `compute_combined_turbulent_fluxes!` init in src w tests update amip experiment slabplanet runs amip runs component model test passes fix combine_surfaces_from_sol! import viz fix add more unit tests docs and interface bug fixes conservation fix `combine_surfaces!` docstring fix revs rev2 doc comment slabplanet runs modularize method import fix collapse `update_sim!` tests run docs + format update ... > import..._fields revs component test fix
LenkaNovak
force-pushed
the
ln/flux-module
branch
from
31747fd
to
9aac5b7
Compare
| get_field(sim::ClimaAtmosSimulation, ::Val{:radiative_energy_flux}) = level(sim.integrator.p.ᶠradiation_flux, half) | ||
| get_field(sim::ClimaAtmosSimulation, ::Val{:liquid_precipitation}) = | ||
| sim.integrator.p.col_integrated_rain .+ sim.integrator.p.col_integrated_snow # all fallen snow melts for now | ||
| get_field(sim::ClimaAtmosSimulation, ::Val{:snow_precipitation}) = sim.integrator.p.col_integrated_snow .* FT(0) |
There was a problem hiding this comment.
I know it was not introduced in this PR, but we can extract FT as
FT = Spaces.undertype(axes(Y.c.ρe_tot))
(or any other Y field) instead of passing it as an argument to the atmos_init
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
valeriabarra
added a commit
that referenced
this pull request
Jun 14, 2023
Closed
LenkaNovak
pushed a commit
that referenced
this pull request
Jun 22, 2023
Apply ClimaLSM API soil resistance changes Apply ClimaComms API changes; remove ClimaCommsMPI Update ClimaAtmos CLI options Use ClimaAtmos v0.14.1 ClimaAtmos change: rename Y.f.w -> Y.f.u₃ ClimaLSM API change: use make_exp_tendency in place of make_ode_function Use ClimaComms.CPUDevice() Remove simulation.is_distributed from Atmos change PR #1634 WIP: Apply changes from surface fluxes rework CA PR #1447 Rebase onto main after PRs #315 & #320 WIP: update to ClimaAtmos surface rework Co-authored-by: Lenka Novak <lenka@caltech.edu> TEMP ONLY: Test CA surface setup fix dev branch Adapt flux calculation given CA current Surface Setup Some WIP fixes w/ Lenka Co-authored-by: Lenka Novak <lenka@caltech.edu> CI: Try Float64 for AMIP modular experiment Increase alloc limit for perf test Update to ClimaAtmos v0.15.0 conserving, need Atmos #1803 test ci with Atmos fix ClimaCore up add refs to TD and CAP init with 0 atmos fluxes Atmos-commit dep perf project test project pip perf Manifest flame fix rm idealinsol true rm idealized insol increase allocs rm debug.jl clean climaatmos_init.jl
LenkaNovak
pushed a commit
that referenced
this pull request
Jun 23, 2023
Apply ClimaLSM API soil resistance changes Apply ClimaComms API changes; remove ClimaCommsMPI Update ClimaAtmos CLI options Use ClimaAtmos v0.14.1 ClimaAtmos change: rename Y.f.w -> Y.f.u₃ ClimaLSM API change: use make_exp_tendency in place of make_ode_function Use ClimaComms.CPUDevice() Remove simulation.is_distributed from Atmos change PR #1634 WIP: Apply changes from surface fluxes rework CA PR #1447 Rebase onto main after PRs #315 & #320 WIP: update to ClimaAtmos surface rework Co-authored-by: Lenka Novak <lenka@caltech.edu> TEMP ONLY: Test CA surface setup fix dev branch Adapt flux calculation given CA current Surface Setup Some WIP fixes w/ Lenka Co-authored-by: Lenka Novak <lenka@caltech.edu> CI: Try Float64 for AMIP modular experiment Increase alloc limit for perf test Update to ClimaAtmos v0.15.0 conserving, need Atmos #1803 test ci with Atmos fix ClimaCore up add refs to TD and CAP init with 0 atmos fluxes Atmos-commit dep perf project test project pip perf Manifest flame fix rm idealinsol true rm idealized insol increase allocs rm debug.jl clean climaatmos_init.jl race condition fix make Float64 default for all Buildkites typo
LenkaNovak
pushed a commit
that referenced
this pull request
Jun 23, 2023
Apply ClimaLSM API soil resistance changes Apply ClimaComms API changes; remove ClimaCommsMPI Update ClimaAtmos CLI options Use ClimaAtmos v0.14.1 ClimaAtmos change: rename Y.f.w -> Y.f.u₃ ClimaLSM API change: use make_exp_tendency in place of make_ode_function Use ClimaComms.CPUDevice() Remove simulation.is_distributed from Atmos change PR #1634 WIP: Apply changes from surface fluxes rework CA PR #1447 Rebase onto main after PRs #315 & #320 WIP: update to ClimaAtmos surface rework Co-authored-by: Lenka Novak <lenka@caltech.edu> TEMP ONLY: Test CA surface setup fix dev branch Adapt flux calculation given CA current Surface Setup Some WIP fixes w/ Lenka Co-authored-by: Lenka Novak <lenka@caltech.edu> CI: Try Float64 for AMIP modular experiment Increase alloc limit for perf test Update to ClimaAtmos v0.15.0 conserving, need Atmos #1803 test ci with Atmos fix ClimaCore up add refs to TD and CAP init with 0 atmos fluxes Atmos-commit dep perf project test project pip perf Manifest flame fix rm idealinsol true rm idealized insol increase allocs rm debug.jl clean climaatmos_init.jl race condition fix make Float64 default for all Buildkites typo up julia 1.8.5 up julia 1.8.5
LenkaNovak
pushed a commit
that referenced
this pull request
Jun 26, 2023
Apply ClimaLSM API soil resistance changes Apply ClimaComms API changes; remove ClimaCommsMPI Update ClimaAtmos CLI options Use ClimaAtmos v0.14.1 ClimaAtmos change: rename Y.f.w -> Y.f.u₃ ClimaLSM API change: use make_exp_tendency in place of make_ode_function Use ClimaComms.CPUDevice() Remove simulation.is_distributed from Atmos change PR #1634 WIP: Apply changes from surface fluxes rework CA PR #1447 Rebase onto main after PRs #315 & #320 WIP: update to ClimaAtmos surface rework Co-authored-by: Lenka Novak <lenka@caltech.edu> TEMP ONLY: Test CA surface setup fix dev branch Adapt flux calculation given CA current Surface Setup Some WIP fixes w/ Lenka Co-authored-by: Lenka Novak <lenka@caltech.edu> CI: Try Float64 for AMIP modular experiment Increase alloc limit for perf test Update to ClimaAtmos v0.15.0 conserving, need Atmos #1803 test ci with Atmos fix ClimaCore up add refs to TD and CAP init with 0 atmos fluxes Atmos-commit dep perf project test project pip perf Manifest flame fix rm idealinsol true rm idealized insol increase allocs rm debug.jl clean climaatmos_init.jl race condition fix make Float64 default for all Buildkites typo up julia 1.8.5 up julia 1.8.5 rev rev rev eps(FT)
LenkaNovak
pushed a commit
that referenced
this pull request
Jun 27, 2023
Apply ClimaLSM API soil resistance changes Apply ClimaComms API changes; remove ClimaCommsMPI Update ClimaAtmos CLI options Use ClimaAtmos v0.14.1 ClimaAtmos change: rename Y.f.w -> Y.f.u₃ ClimaLSM API change: use make_exp_tendency in place of make_ode_function Use ClimaComms.CPUDevice() Remove simulation.is_distributed from Atmos change PR #1634 WIP: Apply changes from surface fluxes rework CA PR #1447 Rebase onto main after PRs #315 & #320 WIP: update to ClimaAtmos surface rework Co-authored-by: Lenka Novak <lenka@caltech.edu> TEMP ONLY: Test CA surface setup fix dev branch Adapt flux calculation given CA current Surface Setup Some WIP fixes w/ Lenka Co-authored-by: Lenka Novak <lenka@caltech.edu> CI: Try Float64 for AMIP modular experiment Increase alloc limit for perf test Update to ClimaAtmos v0.15.0 conserving, need Atmos #1803 test ci with Atmos fix ClimaCore up add refs to TD and CAP init with 0 atmos fluxes Atmos-commit dep perf project test project pip perf Manifest flame fix rm idealinsol true rm idealized insol increase allocs rm debug.jl clean climaatmos_init.jl race condition fix make Float64 default for all Buildkites typo up julia 1.8.5 up julia 1.8.5 rev rev eps(FT) unify q_sfc and q_sfc spec viz_checker fix
LenkaNovak
pushed a commit
that referenced
this pull request
Jun 28, 2023
Apply ClimaLSM API soil resistance changes Apply ClimaComms API changes; remove ClimaCommsMPI Update ClimaAtmos CLI options Use ClimaAtmos v0.14.1 ClimaAtmos change: rename Y.f.w -> Y.f.u₃ ClimaLSM API change: use make_exp_tendency in place of make_ode_function Use ClimaComms.CPUDevice() Remove simulation.is_distributed from Atmos change PR #1634 WIP: Apply changes from surface fluxes rework CA PR #1447 Rebase onto main after PRs #315 & #320 WIP: update to ClimaAtmos surface rework Co-authored-by: Lenka Novak <lenka@caltech.edu> TEMP ONLY: Test CA surface setup fix dev branch Adapt flux calculation given CA current Surface Setup Some WIP fixes w/ Lenka Co-authored-by: Lenka Novak <lenka@caltech.edu> CI: Try Float64 for AMIP modular experiment Increase alloc limit for perf test Update to ClimaAtmos v0.15.0 conserving, need Atmos #1803 test ci with Atmos fix ClimaCore up add refs to TD and CAP init with 0 atmos fluxes Atmos-commit dep perf project test project pip perf Manifest flame fix rm idealinsol true rm idealized insol increase allocs rm debug.jl clean climaatmos_init.jl race condition fix make Float64 default for all Buildkites typo up julia 1.8.5 up julia 1.8.5 rev rev eps(FT) unify q_sfc and q_sfc spec viz_checker fix rev q_vap fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
closes #321 (see for details)