Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps and CLI options #366

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Update deps and CLI options #366

merged 1 commit into from
Jul 28, 2023

Conversation

valeriabarra
Copy link
Member

Purpose

This PR update dependencies again.

Closes #365

Content

  • Solution implemented: Updated all checked-in Manifest files to use latest dependencies. In particular:
↑ ClimaAtmos v0.15.3 ⇒ v0.15.4
↑ ClimaCore v0.10.44 ⇒ v0.10.46
  • I have read and checked the items on the review checklist.

@valeriabarra valeriabarra self-assigned this Jul 28, 2023
@valeriabarra valeriabarra removed the request for review from LenkaNovak July 28, 2023 15:55
@valeriabarra
Copy link
Member Author

CI passes and this PR is ready for review. Thanks!

@valeriabarra
Copy link
Member Author

@LenkaNovak there seems to be tiny numerical differences in u and precipitation in the AMIP paper_plots, but qualitatively, the plots haven't changed much. Let me know what you think!

LenkaNovak
LenkaNovak approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, Valeria! Actually the AMIP run is 20% faster, so something good happened upstream! ;-)

@valeriabarra
Copy link
Member Author

bors r+

@valeriabarra
Copy link
Member Author

LGTM, thanks, Valeria! Actually the AMIP run is 20% faster, so something good happened upstream! ;-)

Great! It was probably due to ClimaCore v0.10.46. There were some changes in some of the geometric transformations that led to some performance gains.

@bors
Copy link
Contributor

bors bot commented Jul 28, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit dc2510e into main Jul 28, 2023
10 checks passed
@bors bors bot deleted the valeria/update-atmos branch July 28, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LenkaNovak LenkaNovak LenkaNovak approved these changes

@juliasloan25 juliasloan25 Awaiting requested review from juliasloan25

Assignees

@valeriabarra valeriabarra

Labels
Dependencies 🔗
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update dependencies again
2 participants
@valeriabarra @LenkaNovak