Diffusive baroclinic wave with thermal slab #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
|
Many TODOs involving external PRs - to be included in the next interaction of this test case. |
LenkaNovak
force-pushed
the
jh_ln/bc_wave_slab
branch
from
77ef0cb
to
0aa53d9
Compare
Co-authored-by: jiahe23 <jiahe23@users.noreply.github.com> visual checks consistent with CA, regrid: 2% error testing local conservation working energy and momentum fluxes juliaformatter + CSTParser v new formatter applied
LenkaNovak
force-pushed
the
jh_ln/bc_wave_slab
branch
from
877303c
to
24dd45e
Compare
|
bors r+ |
approved by Ben |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: jiahe23 jiahe23@users.noreply.github.com
Adds a thermal slab (loosely representing a crude land model) to the 2d_baroclinic_wave ClimaAtmos example, as a stepping stone towards the AMIP simulation.
Demonstrates
weighted_dss!)TODO in this PR:
Follow-up in next PRs:
Spacetype but not the same instance" error) Enable broadcasting with the same spaces and different instances #45ClimaSimulations-excluding) ClimaAtmos interfaceweighted_dss!