Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix BCReader.interpol #373

Merged
merged 1 commit into from
Aug 4, 2023
Merged

fix BCReader.interpol #373

merged 1 commit into from
Aug 4, 2023

Conversation

juliasloan25
Copy link
Member

Purpose

Closes #372

To-do

  • fix logic in interpol
  • add test

  • I have read and checked the items on the review checklist.

@juliasloan25 juliasloan25 self-assigned this Aug 2, 2023
@juliasloan25 juliasloan25 mentioned this pull request Aug 2, 2023
2 tasks
@juliasloan25 juliasloan25 force-pushed the js/interpol branch 2 times, most recently from de3a7e1 to 9c06abd Compare August 3, 2023 22:20
Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, Julia!

src/BCReader.jl Outdated Show resolved Hide resolved
@juliasloan25
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 4, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit c8daf59 into main Aug 4, 2023
10 checks passed
@bors bors bot deleted the js/interpol branch August 4, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

interpol bug
2 participants