Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use time-varying albedo in bucket #394

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Use time-varying albedo in bucket #394

merged 1 commit into from
Sep 1, 2023

Conversation

juliasloan25
Copy link
Member

@juliasloan25 juliasloan25 commented Aug 17, 2023

Purpose

Closes #318

Edit: The interface for ClimaLSM.Bucket.BulkAlbedoTemporal needed to change for compatibility with the coupler. This change has been made in CliMA/ClimaLand.jl#300. ClimaLSM.jl has made an additional patch release for this change, bringing it up to v0.3.1.

To Do

The changes made here will be similar to those made in #202 for reading in albedo from a constant map

  • Use ClimaLSM v0.3.0 v0.3.1
  • Add option in cli_options.jl
    • Change type from Bool to String
  • Add case for temporal map albedo in bucket_init.jl
  • Update buildkite runs to use String albedo_type option
  • Add test for this case in buildkite

  • I have read and checked the items on the review checklist.

experiments/AMIP/modular/cli_options.jl Show resolved Hide resolved
perf/Manifest.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Julia! Buildkite output looks good, but I noticed that the logging doesn't display the run command log (apparently the limit was exceeded). From your local runs, is it obvious why that is? (e.g., lots of warning messages?)

@juliasloan25
Copy link
Member Author

LGTM, thanks Julia! Buildkite output looks good, but I noticed that the logging doesn't display the run command log (apparently the limit was exceeded). From your local runs, is it obvious why that is? (e.g., lots of warning messages?)

@LenkaNovak I've actually been getting a failed process error when I run our driver locally. It happens in rll_mesh when land_fraction is being created. This used to happen sporadically, but recently (for the last few months), it happens every time. I can try running it on the cluster, but it would also be nice to figure out why this happens locally.

@valeriabarra
Copy link
Member

LGTM, thanks Julia! Buildkite output looks good, but I noticed that the logging doesn't display the run command log (apparently the limit was exceeded). From your local runs, is it obvious why that is? (e.g., lots of warning messages?)

@LenkaNovak I've actually been getting a failed process error when I run our driver locally. It happens in rll_mesh when land_fraction is being created. This used to happen sporadically, but recently (for the last few months), it happens every time. I can try running it on the cluster, but it would also be nice to figure out why this happens locally.

Is it the same as these failures that I've seen in my other up_deps.jl PR?

@juliasloan25
Copy link
Member Author

LGTM, thanks Julia! Buildkite output looks good, but I noticed that the logging doesn't display the run command log (apparently the limit was exceeded). From your local runs, is it obvious why that is? (e.g., lots of warning messages?)

@LenkaNovak I've actually been getting a failed process error when I run our driver locally. It happens in rll_mesh when land_fraction is being created. This used to happen sporadically, but recently (for the last few months), it happens every time. I can try running it on the cluster, but it would also be nice to figure out why this happens locally.

Is it the same as these failures that I've seen in my other up_deps.jl PR?

It's similar, but it's a different TempestRemap call that's failing. Here are some screenshots of the error and stacktrace:

Screenshot 2023-08-24 at 9 08 55 AM Screenshot 2023-08-24 at 9 09 14 AM

Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you, @juliasloan25 !

@juliasloan25
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 1, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit c435636 into main Sep 1, 2023
10 checks passed
@bors bors bot deleted the js/use_lsm_albedo branch September 1, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time-varying albedo
3 participants