Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dependencies #438

Merged
merged 1 commit into from
Sep 28, 2023
Merged

update dependencies #438

merged 1 commit into from
Sep 28, 2023

Conversation

juliasloan25
Copy link
Member

@juliasloan25 juliasloan25 commented Sep 27, 2023 •
edited
Loading

Purpose

update dependencies for new releases of ClimaCore, ClimaAtmos, ClimaLSM

closes #433

To-do

note: I wanted to update the compat for SciMLBase to "2" here too, but can't because the compat in ClimaAtmos and ClimaLSM is restricted to "1" #434

  • I have read and checked the items on the review checklist.

@juliasloan25 juliasloan25 self-assigned this Sep 27, 2023
@juliasloan25
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Sep 28, 2023
@bors
Try #438:
82b3f32
@bors
Copy link
Contributor

bors bot commented Sep 28, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

LenkaNovak
LenkaNovak approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @juliasloan25 !Buildkite runs show a slight change in physical runs in slabplanet and AMIP, but this is to be expected given the release changes in ClimaAtmos and ClimaLSM. Performance is improved, so LGTM.

experiments/AMIP/modular/Manifest.toml Show resolved Hide resolved
test/Project.toml Show resolved Hide resolved
@juliasloan25
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 28, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 8128fa2 into main Sep 28, 2023
10 checks passed
@bors bors bot deleted the js/dep-upd branch September 28, 2023 21:28
This was referenced Oct 2, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LenkaNovak LenkaNovak LenkaNovak approved these changes

Assignees

@juliasloan25 juliasloan25

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update for new dep versions
2 participants
@juliasloan25 @LenkaNovak