Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace SIC_init with SIC_current #454

Merged
merged 1 commit into from
Oct 5, 2023
Merged

replace SIC_init with SIC_current #454

merged 1 commit into from
Oct 5, 2023

Conversation

juliasloan25
Copy link
Member

@juliasloan25 juliasloan25 commented Oct 2, 2023

Purpose

closes #334

To-do

Buildkite checks

  • conservation checks (slabplanet)
    • slabplanet plots look identical to current main
  • no singificant change to performance (build_history)
  • reasonalble AMIP paperplot (note: there will be a small behavioral change in the AMIP run, but should be tiny.)
    • plots look identical to me (see below)

current main AMIP paperplot:
image

this PR AMIP paperplot:
image


  • I have read and checked the items on the review checklist.

Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since the plots look identical, it would be good to double check that the SIC is being now being updated (even if it's just an interactive check where you compare the SIC_init and SIC_current fields). Otherwise I think it's good to go!

@juliasloan25
Copy link
Member Author

I've checked that SIC_current is getting updated and is different from SIC_init. I'll go ahead and rebase then merge if CI still looks good

@juliasloan25
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 5, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 2ad06c5 into main Oct 5, 2023
10 checks passed
@bors bors bot deleted the js/sic branch October 5, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change SIC_init to SIC in the driver
2 participants