Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CO2 read #459

Merged
merged 1 commit into from
Oct 9, 2023
Merged

CO2 read #459

merged 1 commit into from
Oct 9, 2023

Conversation

LenkaNovak
Copy link
Collaborator

@LenkaNovak LenkaNovak commented Oct 5, 2023 •
edited
Loading

closes #408

  • I have read and checked the items on the review checklist.

@LenkaNovak LenkaNovak force-pushed the ln/specify-co2 branch 4 times, most recently from 0946ca4 to 05c95b1 Compare October 6, 2023 16:29
@LenkaNovak LenkaNovak marked this pull request as ready for review October 6, 2023 19:35
juliasloan25
juliasloan25 reviewed Oct 6, 2023
View reviewed changes
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me!

I noticed that the CI time for this run is 1hr 42 mins... It would be nice to keep runs to less than 1 hour (or even shorter if we can). Would it be possible to change the length of this simulation, or move it to the longruns if we need it to run for this long? I think we should talk about this for some of the other runs too, but not as part of this PR

experiments/AMIP/modular/components/atmosphere/climaatmos_init.jl Outdated Show resolved Hide resolved
experiments/AMIP/modular/components/atmosphere/climaatmos_init.jl Show resolved Hide resolved
@LenkaNovak
init co2 read
c10ba01 
download art

fix art

art fix

direct link

test - no co2 up

co2 up

clean

gray fix

file fix

revs
@LenkaNovak
Copy link
Collaborator Author

LenkaNovak commented Oct 9, 2023 •
edited
Loading

The code changes look good to me!

I noticed that the CI time for this run is 1hr 42 mins... It would be nice to keep runs to less than 1 hour (or even shorter if we can). Would it be possible to change the length of this simulation, or move it to the longruns if we need it to run for this long? I think we should talk about this for some of the other runs too, but not as part of this PR

Thank you, @juliasloan25 for the review! 🚀

(as discussed offline, we will be splitting the CI runs as in #406 to speed up our workflow. Thanks for the suggestion!)

@LenkaNovak
Copy link
Collaborator Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 9, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 5bb0901 into main Oct 9, 2023
10 checks passed
@bors bors bot deleted the ln/specify-co2 branch October 9, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliasloan25 juliasloan25 juliasloan25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable prescribed CO2
2 participants
@LenkaNovak @juliasloan25