Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move folders to exp/ClimaCore #468

Merged
merged 1 commit into from
Oct 19, 2023
Merged

move folders to exp/ClimaCore #468

merged 1 commit into from
Oct 19, 2023

Conversation

juliasloan25
Copy link
Member

@juliasloan25 juliasloan25 commented Oct 13, 2023 •
edited
Loading

Purpose

closes #458 by using experiment-related folders from src/ to experiments/ClimaCore/. Related tests are moved to a folder called test/experiment_tests.

To Do

  • move src/CoupledSimulations/, src/CouplerState/ to experiments/ClimaCore/
  • move related tests to to test/experiment_tests/
  • rename CoupledSimulation to avoid confusion with Interfacer.CoupledSimulation
  • update docs
  • update ClimaCoupler.jl
  • update experiments code loading to use relocated files
  • I have read and checked the items on the review checklist.

@juliasloan25 juliasloan25 mentioned this pull request Oct 13, 2023
Closed
LenkaNovak
LenkaNovak approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Julia, just a few minor comments! Lmk if any clarification is needed :)

experiments/ClimaCore/sea-ice/slab_ice.jl Outdated Show resolved Hide resolved
test/Project.toml Show resolved Hide resolved
test/experiment_tests/clock.jl Outdated Show resolved Hide resolved
@juliasloan25
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 19, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit b030c43 into main Oct 19, 2023
10 checks passed
@bors bors bot deleted the js/src-mv branch October 19, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LenkaNovak LenkaNovak LenkaNovak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove outdated src/ folders
2 participants
@juliasloan25 @LenkaNovak