Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI on each PR #493

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Run CI on each PR #493

merged 2 commits into from
Nov 10, 2023

Conversation

Sbozzolo
Copy link
Member

@Sbozzolo Sbozzolo commented Nov 6, 2023

Bors is gone.

@Sbozzolo
Copy link
Member Author

Sbozzolo commented Nov 6, 2023

@LenkaNovak, when this has merged, can you try merging a new PR that removes bors.toml to check that everything works as you would expect?

To merge, you can just click the "Enable auto-merge" button on your PR.

@LenkaNovak
Copy link
Collaborator

I'll do that, thanks @Sbozzolo

@Sbozzolo
Copy link
Member Author

Sbozzolo commented Nov 6, 2023

I'll do that, thanks @Sbozzolo

The CI is failing and it seems that there's something wrong in ClimaCoupler. Have you seen this before?

@LenkaNovak
Copy link
Collaborator

Not until this morning (I was just testing if it's just my own branch but it looks like even the main is affected). It was fine on Friday. I can't reproduce this locally, and checking in my local Manifest (as a test) didn't help. Any idea what's changed? @charleskawczynski @simonbyrne

@LenkaNovak
Copy link
Collaborator

Not until this morning (I was just testing if it's just my own branch but it looks like even the main is affected). It was fine on Friday. I can't reproduce this locally, and checking in my local Manifest (as a test) didn't help. Any idea what's changed? @charleskawczynski @simonbyrne

Ahh, the ClimaAtmos release is probably the culprit. I'm pinning to Atmos 0.16.2 now.

@LenkaNovak
Copy link
Collaborator

Not until this morning (I was just testing if it's just my own branch but it looks like even the main is affected). It was fine on Friday. I can't reproduce this locally, and checking in my local Manifest (as a test) didn't help. Any idea what's changed? @charleskawczynski @simonbyrne

Ahh, the ClimaAtmos release is probably the culprit. I'm pinning to Atmos 0.16.2 now.

Hmm, still breaks!

@juliasloan25
Copy link
Member

Now that I think about it, for Clima packages we should pin to the specific patch version we've most recently updated to, since patch releases can introduce breaking changes.

Could this failure be due to not having compats for standard library packages?

@LenkaNovak
Copy link
Collaborator

Now that I think about it, for Clima packages we should pin to the specific patch version we've most recently updated to, since patch releases can introduce breaking changes.

Could this failure be due to not having compats for standard library packages?

Thanks for chiming in, @juliasloan25 ! This is a good point and I agree we should do this. I'm not sure which package is causing this yet though. I've tried to pin all of the major ones and it hasn't worked for me yet... But having cleared my local .julia, I can now reproduce this locally!

@Sbozzolo
Copy link
Member Author

Sbozzolo commented Nov 7, 2023

Now that I think about it, for Clima packages we should pin to the specific patch version we've most recently updated to, since patch releases can introduce breaking changes.

Patch releases should not introduce breaking changes. If they do, please report them (we should learn to be more mindful about this).

There was at least one mistake on ClimaAtmos side. 0.16.3 should have been breaking because all the cache stuff has changed.

Could this failure be due to not having compats for standard library packages?

No, I think that only affects the registrar.

@charleskawczynski
Copy link
Member

@sriharshakandala
Copy link
Member

#493 (comment) cc @sriharshakandala

Looks like this was missed. It should have been tagged 0.17 if this was a breaking release!. We can tag 0.17 in the next day or so!

@Sbozzolo Sbozzolo force-pushed the gb/update_ci branch 2 times, most recently from c0cacac to 6415ad0 Compare November 8, 2023 22:21
Fix OpenMPI_jll 5 problems
@Sbozzolo Sbozzolo merged commit 29ba30b into main Nov 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants