Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ClimaCore experiments #519

Merged
merged 1 commit into from
Dec 1, 2023
Merged

update ClimaCore experiments #519

merged 1 commit into from
Dec 1, 2023

Conversation

juliasloan25
Copy link
Member

@juliasloan25 juliasloan25 commented Nov 22, 2023

Purpose

closes #524

To do

  • get tc1 (heat-diffusion-with-slab) running
  • clean up tc1 (update comments)
  • rm bc-wave-slab, tc2, tc4
  • rename remaining test cases
  • update environments
    • experiments/ (removed)
    • experiments/ClimaCore/
    • experiments/ClimaCore/heat-diffusion-with-slab (removed)
    • experiments/ClimaCore/sea_breeze
  • add remaining test cases to CI
    • heat-diffusion-with-slab
    • sea_breeze
  • update experiments/ClimaCore/README

To do in separate PR

see #528

  • get atm-ocn-lnd running
    • update CLIMAParameters interface
    • replace LandHydrology package (with ClimaLSM)
  • add atm-ocn-lnd to CI

Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @juliasloan25 , looks great! Just a few minor comments. Eventually this should be our entry-level tutorial, so each line should be clear/explained, but we can always do this together during our doc week. Also, it would be good to include the conservation plot in the artifacts on Buildkite. Otherwise, it's good to go. 🚀

.buildkite/pipeline.yml Outdated Show resolved Hide resolved
experiments/ClimaCore/README.md Outdated Show resolved Hide resolved
experiments/ClimaCore/heat-diffusion/run.jl Outdated Show resolved Hide resolved
experiments/ClimaCore/heat-diffusion/run.jl Outdated Show resolved Hide resolved
experiments/ClimaCore/heat-diffusion/run.jl Outdated Show resolved Hide resolved
experiments/ClimaCore/heat-diffusion/run.jl Show resolved Hide resolved
experiments/ClimaCore/heat-diffusion/run.jl Show resolved Hide resolved
@juliasloan25 juliasloan25 merged commit e8e1555 into main Dec 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clean up ClimaCore test cases
2 participants