-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Manifest and update gitignore. #54
Conversation
docs/build/ | ||
docs/src/generated/ | ||
!docs/src/assets/*.png | ||
!docs/src/assets/*.svg | ||
!docs/src/images/*.png | ||
|
||
# Experiments | ||
!experiments/AMIP/*/Manifest.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LenkaNovak if there are experiments that require a manifest you can add a similar line to the .gitignore.
version = "0.1.0" | ||
|
||
[deps] | ||
ClimaCommsMPI = "5f86816e-8b66-43b2-912e-75384f99de49" | ||
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a" | ||
OrdinaryDiffEq = "1dea7af3-3e70-54e6-95c3-0bf5283fa5ed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly, only packages that are required for code in src
should live in the Project.toml. Packages like SciMLBase and OrdinaryDiffEq are just needed for running models and can live in the Project.toml files in experiments/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
bors r+ |
Build succeeded: |
No description provided.