Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use refs for long variable names #627

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Use refs for long variable names #627

merged 1 commit into from
Mar 5, 2024

Conversation

anastasia-popova
Copy link
Contributor

@anastasia-popova anastasia-popova commented Feb 14, 2024 •
edited by LenkaNovak
Loading

Purpose

Cleans up long variable names found in experiments/AMIP and src

closes #234

To-do

Content

-Found long variable names in experiments/AMIP and src
-Locally renamed with refs
-Verified that there is no change through bit wise comparison

  • I have read and checked the items on the review checklist.

@anastasia-popova anastasia-popova changed the title Get rid of long refs Use refs for long variable names Feb 14, 2024
@anastasia-popova anastasia-popova linked an issue Feb 14, 2024 that may be closed by this pull request
use refs for long variable names #448
Closed
3 tasks
@anastasia-popova anastasia-popova marked this pull request as draft February 14, 2024 21:23
@anastasia-popova anastasia-popova marked this pull request as ready for review February 21, 2024 18:00
@anastasia-popova anastasia-popova self-assigned this Feb 21, 2024
juliasloan25
juliasloan25 reviewed Feb 21, 2024
View reviewed changes
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, thank you Anastasia! I just left a couple of suggestions. After you address those, you can re-request my review and it should be good to go :)

experiments/AMIP/components/atmosphere/climaatmos_init.jl Outdated Show resolved Hide resolved
experiments/AMIP/components/atmosphere/climaatmos_init.jl Outdated Show resolved Hide resolved
LenkaNovak
LenkaNovak reviewed Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you, @anastasia-popova! I only had a few minor comments.

experiments/AMIP/components/atmosphere/climaatmos_init.jl Show resolved Hide resolved
experiments/AMIP/components/atmosphere/climaatmos_init.jl Outdated Show resolved Hide resolved
experiments/AMIP/components/land/bucket_utils.jl Show resolved Hide resolved
juliasloan25
juliasloan25 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! You can rebase on main and then if Lenka approves you can merge :)

@anastasia-popova anastasia-popova merged commit 7f0f85b into main Mar 5, 2024
6 of 7 checks passed
@anastasia-popova anastasia-popova deleted the ap/refs branch March 5, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LenkaNovak LenkaNovak LenkaNovak approved these changes

@juliasloan25 juliasloan25 juliasloan25 approved these changes

Assignees

@anastasia-popova anastasia-popova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use refs for long variable names QA improvements
3 participants
@anastasia-popova @LenkaNovak @juliasloan25