-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial Interfacer cleanup #644
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
juliasloan25
force-pushed
the
js/interfacer
branch
from
February 27, 2024 22:50
42e8b68
to
bf737e0
Compare
5 tasks
juliasloan25
force-pushed
the
js/interfacer
branch
from
February 28, 2024 01:25
bf737e0
to
3d518fe
Compare
LenkaNovak
reviewed
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, Julia, thank you! I left a few comments. If you need help with any of TODOs, let me know once everything else is good to go and I can add the remaining info.
juliasloan25
force-pushed
the
js/interfacer
branch
2 times, most recently
from
February 29, 2024 19:11
0d34dfb
to
236aaae
Compare
juliasloan25
force-pushed
the
js/interfacer
branch
from
February 29, 2024 23:15
236aaae
to
64df52d
Compare
LenkaNovak
approved these changes
Mar 4, 2024
juliasloan25
force-pushed
the
js/interfacer
branch
4 times, most recently
from
March 5, 2024 22:01
7862425
to
08e6cd2
Compare
juliasloan25
force-pushed
the
js/interfacer
branch
from
March 5, 2024 22:41
08e6cd2
to
23408c8
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
First steps of Interfacer cleanup. Some of it (e.g. restructuring) will be done in separate PRs so this one doesn't get too big.
closes #339
To-do
Content
get_field
surfacestub
renaming variables
get_model_state_vector
->get_model_prog_state
restructuring
docs
QA
To Do in future PRs
<model>.jl
, combine bucket_init and bucket_utils -> bucket.jl; separate required vs model-specific (internal) functions and objects in component model files - see restructure component models #647Remaining questions
update_turbulent_fluxes_point
? or just surface models as it is currently?update_turbulent_fluxes_point
is called by surface models only. Once the surfaces are updated and fluxes per each fractional surface calculated, the coupler combines the fluxes so that we have one flux value per atmos grid point, and we update atmos in the same way as for the CombinedStateFluxes. I will work on the flux calculation interface in a few weeks, with the aim of making this function more transparent and performant. :)