Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional diagnostics to CAD extensions #757

Merged
merged 1 commit into from
May 4, 2024
Merged

Add additional diagnostics to CAD extensions #757

merged 1 commit into from
May 4, 2024

Conversation

LenkaNovak
Copy link
Collaborator

@LenkaNovak LenkaNovak commented Apr 29, 2024 •
edited
Loading

closes #756

  • I have read and checked the items on the review checklist.

@LenkaNovak LenkaNovak marked this pull request as ready for review April 29, 2024 18:14
juliasloan25
juliasloan25 reviewed Apr 29, 2024
View reviewed changes
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Lenka! I left some comments

experiments/AMIP/components/atmosphere/climaatmos_extra_diags.jl Show resolved Hide resolved
experiments/AMIP/components/atmosphere/climaatmos_extra_diags.jl Outdated Show resolved Hide resolved
experiments/AMIP/components/atmosphere/climaatmos_extra_diags.jl Outdated Show resolved Hide resolved
experiments/AMIP/components/atmosphere/climaatmos_extra_diags.jl Outdated Show resolved Hide resolved
experiments/AMIP/components/atmosphere/climaatmos_extra_diags.jl Show resolved Hide resolved
experiments/AMIP/components/atmosphere/climaatmos_extra_diags.jl Outdated Show resolved Hide resolved
@LenkaNovak LenkaNovak force-pushed the ln/hierarchy-diagnsotics branch 2 times, most recently from 2ab8a47 to af33545 Compare May 1, 2024 05:35
juliasloan25
juliasloan25 approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LenkaNovak LenkaNovak force-pushed the ln/hierarchy-diagnsotics branch 2 times, most recently from 5da5582 to 38669d5 Compare May 4, 2024 03:36
@LenkaNovak
add mass_strf, stab, vt, egr
7fe9b2d 
CC

cleanup

rev

rm mask

bump

CommonDataModel = "=0.3.5"

sea breeze

rebase
@LenkaNovak LenkaNovak enabled auto-merge May 4, 2024 07:31
@LenkaNovak LenkaNovak merged commit 34553a4 into main May 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennisYatunin dennisYatunin dennisYatunin left review comments

@juliasloan25 juliasloan25 juliasloan25 approved these changes

@anastasia-popova anastasia-popova Awaiting requested review from anastasia-popova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add additional diagnostics to CAD extensions
3 participants
@LenkaNovak @dennisYatunin @juliasloan25