Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade climacore and climaatmos #81

Merged
merged 1 commit into from
Jul 8, 2022
Merged

upgrade climacore and climaatmos #81

merged 1 commit into from
Jul 8, 2022

Conversation

kmdeck
Copy link
Contributor

@kmdeck kmdeck commented Jul 7, 2022

PULL REQUEST

Purpose and Content

Upgrade to latest CA release 0.2.0; requires latest CC 10.6
Also, fixed the buildkite run for the mpi earth so that the plots are saved correctly.

Benefits and Risks

Remain up-to-date with CA.

@kmdeck kmdeck requested review from jiahe23 and LenkaNovak July 7, 2022 18:55
@@ -244,7 +242,7 @@ uuid = "c8b6d40d-e815-466f-95ae-c48aefa668fa"
version = "0.7.1"

[[deps.ClimaCoupler]]
deps = ["PrettyTables", "SciMLBase"]
deps = ["ClimaCore", "PrettyTables", "SciMLBase"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change necessary? I once ran into problems when adding CC here...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm im not sure if it is necessary! The manifest was updated automatically when I rm-ed and add-ed back in CC and CA...

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems as long as it works

pipeline artifact path

pipeline artifact path 2

path

path issue
@kmdeck
Copy link
Contributor Author

kmdeck commented Jul 8, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 8, 2022

@bors bors bot merged commit 4916789 into main Jul 8, 2022
@bors bors bot deleted the upgrade_cc_ca branch July 8, 2022 21:38
@kmdeck kmdeck mentioned this pull request Jul 18, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants